fix: stream records lazily in write_records and _execute_chunk_v2

Author: shivamsharma2106

splunklib/searchcommands/generating_command.py

@@ -208,16 +208,12 @@ def _execute(self, ifile, process):
 
     def _execute_chunk_v2(self, process, chunk):
         count = 0
-        records = []
         for row in process:
-            records.append(row)
+            self._record_writer.write_record(row)
             count += 1
             if count == self._record_writer._maxresultrows:
                 break
 
-        for row in records:
-            self._record_writer.write_record(row)
-
         if count == self._record_writer._maxresultrows:
             self._finished = False
         else:

splunklib/searchcommands/internals.py

@@ -527,7 +527,8 @@ def write_record(self, record):
 
     def write_records(self, records):
         self._ensure_validity()
-        records = [] if records is NotImplemented else list(records)
+        if records is NotImplemented:
+            return
         write_record = self._write_record
         for record in records:
             write_record(record)