The main controller-manager image reference is overridden via the handy kustomize edit set image functionality seen here.
With #551, we're now correctly setting the appropriate env vars on the controller-manager Deployment to set the shim-downloader and node-installer images. However, these are currently hard-coded to their canonical values (eg ghcr.io/spinframework/shim-downloader:latest, etc).
It would be nice to find a way to support overriding these image reference values to respect what REGISTRY, TAG, etc is set to in the developer's environment. In other words, if REGISTRY=myregistry and TAG=mytag, the final env values on the controller-manager Deployment should be myregistry/shim-downloader:mytag for SHIM_DOWNLOADER_IMAGE and myregistry/node-installer:mytag for SHIM_NODE_INSTALLER_IMAGE.
The main controller-manager image reference is overridden via the handy
kustomize edit set imagefunctionality seen here.With #551, we're now correctly setting the appropriate env vars on the controller-manager Deployment to set the shim-downloader and node-installer images. However, these are currently hard-coded to their canonical values (eg
ghcr.io/spinframework/shim-downloader:latest, etc).It would be nice to find a way to support overriding these image reference values to respect what
REGISTRY,TAG, etc is set to in the developer's environment. In other words, ifREGISTRY=myregistryandTAG=mytag, the final env values on the controller-manager Deployment should bemyregistry/shim-downloader:mytagforSHIM_DOWNLOADER_IMAGEandmyregistry/node-installer:mytagforSHIM_NODE_INSTALLER_IMAGE.