revert JoinPath in createHTTPRequest because the input path could contain a query string

peterguy · peterguy · commit 0dafd5d2d055 · 2026-03-09T09:45:22.000-07:00
diff --git a/internal/api/api.go b/internal/api/api.go
@@ -158,7 +158,8 @@ func (c *client) NewHTTPRequest(ctx context.Context, method, p string, body io.R
 }
 
 func (c *client) createHTTPRequest(ctx context.Context, method, p string, body io.Reader) (*http.Request, error) {
-	req, err := http.NewRequestWithContext(ctx, method, c.opts.EndpointURL.JoinPath(p).String(), body)
+	// Can't use c.opts.EndpointURL.JoinPaht(p) here because `p` could contain a query string
+	req, err := http.NewRequestWithContext(ctx, method, c.opts.EndpointURL.String()+"/"+p, body)
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,8 @@ func (c *client) NewHTTPRequest(ctx context.Context, method, p string, body io.R`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`func (c client) createHTTPRequest(ctx context.Context, method, p string, body io.Reader) (http.Request, error) {`
`161`		`- req, err := http.NewRequestWithContext(ctx, method, c.opts.EndpointURL.JoinPath(p).String(), body)`
	`161`	+ // Can't use c.opts.EndpointURL.JoinPaht(p) here because `p` could contain a query string
	`162`	`+ req, err := http.NewRequestWithContext(ctx, method, c.opts.EndpointURL.String()+"/"+p, body)`
`162`	`163`	`if err != nil {`
`163`	`164`	`return nil, err`
`164`	`165`	`}`