Block pg_cancel_backend and pg_terminate_backend in read-only mode#854
Open
sosedoff wants to merge 1 commit into
Open
Block pg_cancel_backend and pg_terminate_backend in read-only mode#854sosedoff wants to merge 1 commit into
sosedoff wants to merge 1 commit into
Conversation
Users could terminate or cancel queries via the activity panel even when read-only mode was enabled, since pg_cancel_backend() is a SELECT-based function call that bypasses the keyword restriction. Add a regex check for these functions to the restricted keywords filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg_cancel_backend()andpg_terminate_backend()are SELECT-based function calls that bypass the existing keyword restrictioncontainsRestrictedKeywordsfilterTest plan
TestContainsRestrictedKeywordspasses with new cases forpg_cancel_backendandpg_terminate_backend