refactor: 코드리뷰 수정사항 반영

- UnivApplyInfo University fetchType LAZY로 변경
- 컨벤션 수정
- findRandomByTerm함수 nativeQuery제거 및 Pageable로 LIMIT 구현

Author: lsy1307

src/main/java/com/example/solidconnection/university/domain/UnivApplyInfo.java

@@ -77,10 +77,10 @@ public class UnivApplyInfo {
     @Column(length = 1000)
     private String details;
 
-    @OneToMany(mappedBy = "univApplyInfo", cascade = CascadeType.ALL, orphanRemoval = true, fetch = FetchType.EAGER)
+    @OneToMany(mappedBy = "univApplyInfo", cascade = CascadeType.ALL, orphanRemoval = true)
     private Set<LanguageRequirement> languageRequirements = new HashSet<>();
 
-    @ManyToOne(fetch = FetchType.EAGER)
+    @ManyToOne(fetch = FetchType.LAZY)
     private University university;
 
     public void addLanguageRequirements(LanguageRequirement languageRequirements) {

src/main/java/com/example/solidconnection/university/repository/UnivApplyInfoRepository.java

@@ -3,13 +3,13 @@
 import com.example.solidconnection.common.exception.CustomException;
 import com.example.solidconnection.university.domain.UnivApplyInfo;
 import com.example.solidconnection.university.repository.custom.UnivApplyInfoFilterRepository;
+import org.springframework.data.domain.Pageable;
 import org.springframework.data.jpa.repository.JpaRepository;
 import org.springframework.data.jpa.repository.Query;
 import org.springframework.data.repository.query.Param;
 import org.springframework.stereotype.Repository;
 
 import java.util.List;
-import java.util.stream.Collectors;
 
 import static com.example.solidconnection.common.exception.ErrorCode.UNIV_APPLY_INFO_NOT_FOUND;
 
@@ -37,14 +37,17 @@ OR r.code IN (
     """)
     List<UnivApplyInfo> findAllBySiteUsersInterestedCountryOrRegionAndTerm(@Param("siteUserId") Long siteUserId, @Param("term") String term);
 
-    @Query(value = """
-                SELECT *
-                FROM university_info_for_apply
-                WHERE term = :term
-                ORDER BY RAND()
-                LIMIT :limitNum
-            """, nativeQuery = true)
-    List<UnivApplyInfo> findRandomByTerm(@Param("term") String term, @Param("limitNum") int limitNum);
+    @Query("""
+        SELECT uai
+        FROM UnivApplyInfo uai
+        LEFT JOIN FETCH uai.languageRequirements lr
+        LEFT JOIN FETCH uai.university u
+        LEFT JOIN FETCH u.country c
+        LEFT JOIN FETCH u.region r
+        WHERE uai.term = :term
+        ORDER BY FUNCTION('RAND')
+    """)
+    List<UnivApplyInfo> findRandomByTerm(@Param("term") String term, Pageable pageable); // JPA에서 LIMIT 사용이 불가하므로 Pageable을 통해 0page에서 정해진 개수 만큼 가져오는 방식으로 구현
 
     default UnivApplyInfo getUnivApplyInfoById(Long id) {
         return findById(id)

src/main/java/com/example/solidconnection/university/service/GeneralUnivApplyInfoRecommendService.java

@@ -7,6 +7,8 @@
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.boot.context.event.ApplicationReadyEvent;
 import org.springframework.context.event.EventListener;
+import org.springframework.data.domain.PageRequest;
+import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
 
 import java.util.List;
@@ -30,6 +32,7 @@ public class GeneralUnivApplyInfoRecommendService {
 
     @EventListener(ApplicationReadyEvent.class)
     public void init() {
-        generalRecommends = univApplyInfoRepository.findRandomByTerm(term, RECOMMEND_UNIV_APPLY_INFO_NUM);
+        Pageable page = PageRequest.of(0, RECOMMEND_UNIV_APPLY_INFO_NUM);
+        generalRecommends = univApplyInfoRepository.findRandomByTerm(term, page);
     }
 }

src/main/java/com/example/solidconnection/university/service/UnivApplyInfoRecommendService.java

@@ -59,6 +59,7 @@ private List<UnivApplyInfo> getGeneralRecommendsExcludingSelected(List<UnivApply
         int needed = RECOMMEND_UNIV_APPLY_INFO_NUM - alreadyPicked.size();
         return generalRecommend.subList(0, Math.min(needed, generalRecommend.size()));
     }
+
     /*
      * 공통 추천 대학교를 불러온다.
      * */