Skip to content

Commit bf94adf

Browse files
committed
refactor: UnivApplyInfo 사용하도록 테스트 코드 변경
1 parent 3dae69a commit bf94adf

5 files changed

Lines changed: 34 additions & 34 deletions

File tree

src/test/java/com/example/solidconnection/university/fixture/LanguageRequirementFixture.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,43 +12,43 @@ public class LanguageRequirementFixture {
1212

1313
private final LanguageRequirementFixtureBuilder languageRequirementFixtureBuilder;
1414

15-
public LanguageRequirement 토플_80(UnivApplyInfo universityInfo) {
15+
public LanguageRequirement 토플_80(UnivApplyInfo univApplyInfo) {
1616
return languageRequirementFixtureBuilder
1717
.languageTestType(LanguageTestType.TOEFL_IBT)
1818
.minScore("80")
19-
.universityInfoForApply(universityInfo)
19+
.univApplyInfo(univApplyInfo)
2020
.create();
2121
}
2222

23-
public LanguageRequirement 토플_70(UnivApplyInfo universityInfo) {
23+
public LanguageRequirement 토플_70(UnivApplyInfo univApplyInfo) {
2424
return languageRequirementFixtureBuilder
2525
.languageTestType(LanguageTestType.TOEFL_IBT)
2626
.minScore("70")
27-
.universityInfoForApply(universityInfo)
27+
.univApplyInfo(univApplyInfo)
2828
.create();
2929
}
3030

31-
public LanguageRequirement 토익_800(UnivApplyInfo universityInfo) {
31+
public LanguageRequirement 토익_800(UnivApplyInfo univApplyInfo) {
3232
return languageRequirementFixtureBuilder
3333
.languageTestType(LanguageTestType.TOEIC)
3434
.minScore("800")
35-
.universityInfoForApply(universityInfo)
35+
.univApplyInfo(univApplyInfo)
3636
.create();
3737
}
3838

39-
public LanguageRequirement 토익_900(UnivApplyInfo universityInfo) {
39+
public LanguageRequirement 토익_900(UnivApplyInfo univApplyInfo) {
4040
return languageRequirementFixtureBuilder
4141
.languageTestType(LanguageTestType.TOEIC)
4242
.minScore("900")
43-
.universityInfoForApply(universityInfo)
43+
.univApplyInfo(univApplyInfo)
4444
.create();
4545
}
4646

47-
public LanguageRequirement JLPT_N2(UnivApplyInfo universityInfo) {
47+
public LanguageRequirement JLPT_N2(UnivApplyInfo univApplyInfo) {
4848
return languageRequirementFixtureBuilder
4949
.languageTestType(LanguageTestType.JLPT)
5050
.minScore("N2")
51-
.universityInfoForApply(universityInfo)
51+
.univApplyInfo(univApplyInfo)
5252
.create();
5353
}
5454
}

src/test/java/com/example/solidconnection/university/fixture/LanguageRequirementFixtureBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public LanguageRequirementFixtureBuilder minScore(String minScore) {
2727
return this;
2828
}
2929

30-
public LanguageRequirementFixtureBuilder universityInfoForApply(UnivApplyInfo univApplyInfo) {
30+
public LanguageRequirementFixtureBuilder univApplyInfo(UnivApplyInfo univApplyInfo) {
3131
this.univApplyInfo = univApplyInfo;
3232
return this;
3333
}

src/test/java/com/example/solidconnection/university/fixture/UnivApplyInfoFixture.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,79 +16,79 @@ public class UnivApplyInfoFixture {
1616
public String term;
1717

1818
public UnivApplyInfo 괌대학_A_지원_정보() {
19-
return univApplyInfoFixtureBuilder.universityInfoForApply()
19+
return univApplyInfoFixtureBuilder.univApplyInfo()
2020
.term(term)
2121
.koreanName("괌대학(A형)")
2222
.university(universityFixture.괌_대학())
2323
.create();
2424
}
2525

2626
public UnivApplyInfo 괌대학_B_지원_정보() {
27-
return univApplyInfoFixtureBuilder.universityInfoForApply()
27+
return univApplyInfoFixtureBuilder.univApplyInfo()
2828
.term(term)
2929
.koreanName("괌대학(B형)")
3030
.university(universityFixture.괌_대학())
3131
.create();
3232
}
3333

3434
public UnivApplyInfo 네바다주립대학_라스베이거스_지원_정보() {
35-
return univApplyInfoFixtureBuilder.universityInfoForApply()
35+
return univApplyInfoFixtureBuilder.univApplyInfo()
3636
.term(term)
3737
.koreanName("네바다주립대학 라스베이거스(B형)")
3838
.university(universityFixture.네바다주립_대학_라스베이거스())
3939
.create();
4040
}
4141

4242
public UnivApplyInfo 메모리얼대학_세인트존스_A_지원_정보() {
43-
return univApplyInfoFixtureBuilder.universityInfoForApply()
43+
return univApplyInfoFixtureBuilder.univApplyInfo()
4444
.term(term)
4545
.koreanName("메모리얼 대학 세인트존스(A형)")
4646
.university(universityFixture.메모리얼_대학_세인트존스())
4747
.create();
4848
}
4949

5050
public UnivApplyInfo 서던덴마크대학교_지원_정보() {
51-
return univApplyInfoFixtureBuilder.universityInfoForApply()
51+
return univApplyInfoFixtureBuilder.univApplyInfo()
5252
.term(term)
5353
.koreanName("서던덴마크대학교")
5454
.university(universityFixture.서던덴마크_대학())
5555
.create();
5656
}
5757

5858
public UnivApplyInfo 코펜하겐IT대학_지원_정보() {
59-
return univApplyInfoFixtureBuilder.universityInfoForApply()
59+
return univApplyInfoFixtureBuilder.univApplyInfo()
6060
.term(term)
6161
.koreanName("코펜하겐 IT대학")
6262
.university(universityFixture.코펜하겐IT_대학())
6363
.create();
6464
}
6565

6666
public UnivApplyInfo 그라츠대학_지원_정보() {
67-
return univApplyInfoFixtureBuilder.universityInfoForApply()
67+
return univApplyInfoFixtureBuilder.univApplyInfo()
6868
.term(term)
6969
.koreanName("그라츠 대학")
7070
.university(universityFixture.그라츠_대학())
7171
.create();
7272
}
7373

7474
public UnivApplyInfo 그라츠공과대학_지원_정보() {
75-
return univApplyInfoFixtureBuilder.universityInfoForApply()
75+
return univApplyInfoFixtureBuilder.univApplyInfo()
7676
.term(term)
7777
.koreanName("그라츠공과대학")
7878
.university(universityFixture.그라츠공과_대학())
7979
.create();
8080
}
8181

8282
public UnivApplyInfo 린츠_카톨릭대학_지원_정보() {
83-
return univApplyInfoFixtureBuilder.universityInfoForApply()
83+
return univApplyInfoFixtureBuilder.univApplyInfo()
8484
.term(term)
8585
.koreanName("린츠 카톨릭 대학교")
8686
.university(universityFixture.린츠_카톨릭_대학())
8787
.create();
8888
}
8989

9090
public UnivApplyInfo 메이지대학_지원_정보() {
91-
return univApplyInfoFixtureBuilder.universityInfoForApply()
91+
return univApplyInfoFixtureBuilder.univApplyInfo()
9292
.term(term)
9393
.koreanName("메이지대학")
9494
.university(universityFixture.메이지_대학())

src/test/java/com/example/solidconnection/university/fixture/UnivApplyInfoFixtureBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class UnivApplyInfoFixtureBuilder {
2121
private String koreanName;
2222
private University university;
2323

24-
public UnivApplyInfoFixtureBuilder universityInfoForApply() {
24+
public UnivApplyInfoFixtureBuilder univApplyInfo() {
2525
return new UnivApplyInfoFixtureBuilder(univApplyInfoRepository);
2626
}
2727

src/test/java/com/example/solidconnection/university/repository/UniversityLikeRepositoryTest.java renamed to src/test/java/com/example/solidconnection/university/repository/LikedUnivApplyInfoRepositoryTest.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
@TestContainerSpringBootTest
1818
@DisplayName("대학교 좋아요 레파지토리 테스트")
19-
public class UniversityLikeRepositoryTest {
19+
public class LikedUnivApplyInfoRepositoryTest {
2020

2121
@Autowired
2222
private LikedUnivApplyInfoRepository likedUnivApplyInfoRepository;
@@ -34,12 +34,12 @@ class 사용자와_좋아요한_대학은_복합_유니크_제약조건을_갖
3434
void 같은_사용자가_같은_대학에_중복으로_좋아요하면_예외_응답을_반환한다() {
3535
// given
3636
SiteUser user = siteUserFixture.사용자();
37-
UnivApplyInfo university = univApplyInfoFixture.괌대학_A_지원_정보();
37+
UnivApplyInfo univApplyInfo = univApplyInfoFixture.괌대학_A_지원_정보();
3838

39-
LikedUnivApplyInfo firstLike = createLikedUniversity(user, university);
39+
LikedUnivApplyInfo firstLike = createLikedUnivApplyInfo(user, univApplyInfo);
4040
likedUnivApplyInfoRepository.save(firstLike);
4141

42-
LikedUnivApplyInfo secondLike = createLikedUniversity(user, university);
42+
LikedUnivApplyInfo secondLike = createLikedUnivApplyInfo(user, univApplyInfo);
4343

4444
// when & then
4545
assertThatCode(() -> likedUnivApplyInfoRepository.save(secondLike))
@@ -51,12 +51,12 @@ class 사용자와_좋아요한_대학은_복합_유니크_제약조건을_갖
5151
// given
5252
SiteUser user1 = siteUserFixture.사용자(1, "user1");
5353
SiteUser user2 = siteUserFixture.사용자(2, "user2");
54-
UnivApplyInfo university = univApplyInfoFixture.괌대학_A_지원_정보();
54+
UnivApplyInfo univApplyInfo = univApplyInfoFixture.괌대학_A_지원_정보();
5555

56-
LikedUnivApplyInfo firstLike = createLikedUniversity(user1, university);
56+
LikedUnivApplyInfo firstLike = createLikedUnivApplyInfo(user1, univApplyInfo);
5757
likedUnivApplyInfoRepository.save(firstLike);
5858

59-
LikedUnivApplyInfo secondLike = createLikedUniversity(user2, university);
59+
LikedUnivApplyInfo secondLike = createLikedUnivApplyInfo(user2, univApplyInfo);
6060

6161
// when & then
6262
assertThatCode(() -> likedUnivApplyInfoRepository.save(secondLike)).doesNotThrowAnyException();
@@ -66,20 +66,20 @@ class 사용자와_좋아요한_대학은_복합_유니크_제약조건을_갖
6666
void 같은_사용자가_다른_대학에_좋아요하면_정상_저장된다() {
6767
// given
6868
SiteUser user = siteUserFixture.사용자();
69-
UnivApplyInfo university1 = univApplyInfoFixture.괌대학_A_지원_정보();
70-
UnivApplyInfo university2 = univApplyInfoFixture.메이지대학_지원_정보();
69+
UnivApplyInfo univApplyInfo1 = univApplyInfoFixture.괌대학_A_지원_정보();
70+
UnivApplyInfo univApplyInfo2 = univApplyInfoFixture.메이지대학_지원_정보();
7171

72-
LikedUnivApplyInfo firstLike = createLikedUniversity(user, university1);
72+
LikedUnivApplyInfo firstLike = createLikedUnivApplyInfo(user, univApplyInfo1);
7373
likedUnivApplyInfoRepository.save(firstLike);
7474

75-
LikedUnivApplyInfo secondLike = createLikedUniversity(user, university2);
75+
LikedUnivApplyInfo secondLike = createLikedUnivApplyInfo(user, univApplyInfo2);
7676

7777
// when & then
7878
assertThatCode(() -> likedUnivApplyInfoRepository.save(secondLike)).doesNotThrowAnyException();
7979
}
8080
}
8181

82-
private LikedUnivApplyInfo createLikedUniversity(SiteUser siteUser, UnivApplyInfo univApplyInfo) {
82+
private LikedUnivApplyInfo createLikedUnivApplyInfo(SiteUser siteUser, UnivApplyInfo univApplyInfo) {
8383
return LikedUnivApplyInfo.builder()
8484
.siteUser(siteUser)
8585
.univApplyInfo(univApplyInfo)

0 commit comments

Comments
 (0)