Skip to content

Commit 32cb72f

Browse files
committed
refactor: 불필요한 siteUser 재조회 수정
- ScoreService에서 siteUser정보를 다시 불러오는 로직 삭제
1 parent df10149 commit 32cb72f

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

src/main/java/com/example/solidconnection/score/service/ScoreService.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ public class ScoreService {
4343
public Long submitGpaScore(SiteUser siteUser, GpaScoreRequest gpaScoreRequest, MultipartFile file) {
4444
UploadedFileUrlResponse uploadedFile = s3Service.uploadFile(file, ImgType.GPA);
4545
Gpa gpa = new Gpa(gpaScoreRequest.gpa(), gpaScoreRequest.gpaCriteria(), uploadedFile.fileUrl());
46-
SiteUser siteUser1 = siteUserRepository.findById(siteUser.getId()).orElseThrow(() -> new CustomException(USER_NOT_FOUND));
47-
GpaScore newGpaScore = new GpaScore(gpa, siteUser1);
46+
GpaScore newGpaScore = new GpaScore(gpa, siteUser);
4847
GpaScore savedNewGpaScore = gpaScoreRepository.save(newGpaScore);
4948
return savedNewGpaScore.getId();
5049
}

0 commit comments

Comments
 (0)