Skip to content

Commit 2d5f877

Browse files
committed
refactor: long id를 받도록 S3Controller 수정
1 parent c1b124f commit 2d5f877

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

src/main/java/com/example/solidconnection/s3/controller/S3Controller.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import com.example.solidconnection.s3.dto.UploadedFileUrlResponse;
66
import com.example.solidconnection.s3.dto.urlPrefixResponse;
77
import com.example.solidconnection.s3.service.S3Service;
8-
import com.example.solidconnection.siteuser.domain.SiteUser;
98
import lombok.RequiredArgsConstructor;
109
import org.springframework.beans.factory.annotation.Value;
1110
import org.springframework.http.ResponseEntity;
@@ -45,11 +44,11 @@ public ResponseEntity<UploadedFileUrlResponse> uploadPreProfileImage(
4544

4645
@PostMapping("/profile/post")
4746
public ResponseEntity<UploadedFileUrlResponse> uploadPostProfileImage(
48-
@AuthorizedUser SiteUser siteUser,
47+
@AuthorizedUser long siteUserId,
4948
@RequestParam("file") MultipartFile imageFile
5049
) {
5150
UploadedFileUrlResponse profileImageUrl = s3Service.uploadFile(imageFile, ImgType.PROFILE);
52-
s3Service.deleteExProfile(siteUser);
51+
s3Service.deleteExProfile(siteUserId);
5352
return ResponseEntity.ok(profileImageUrl);
5453
}
5554

src/main/java/com/example/solidconnection/s3/service/S3Service.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import static com.example.solidconnection.common.exception.ErrorCode.NOT_ALLOWED_FILE_EXTENSIONS;
66
import static com.example.solidconnection.common.exception.ErrorCode.S3_CLIENT_EXCEPTION;
77
import static com.example.solidconnection.common.exception.ErrorCode.S3_SERVICE_EXCEPTION;
8+
import static com.example.solidconnection.common.exception.ErrorCode.USER_NOT_FOUND;
89

910
import com.amazonaws.AmazonServiceException;
1011
import com.amazonaws.SdkClientException;
@@ -15,6 +16,7 @@
1516
import com.example.solidconnection.s3.dto.UploadedFileUrlResponse;
1617
import com.example.solidconnection.siteuser.domain.SiteUser;
1718
import com.example.solidconnection.siteuser.repository.SiteUserRepository;
19+
import jakarta.transaction.Transactional;
1820
import java.util.ArrayList;
1921
import java.util.Arrays;
2022
import java.util.List;
@@ -109,7 +111,10 @@ private String getFileExtension(String fileName) {
109111
* - 기존 파일의 key(S3파일명)를 찾는다.
110112
* - S3에서 파일을 삭제한다.
111113
* */
112-
public void deleteExProfile(SiteUser siteUser) {
114+
@Transactional
115+
public void deleteExProfile(long siteUserId) {
116+
SiteUser siteUser = siteUserRepository.findById(siteUserId)
117+
.orElseThrow(() -> new CustomException(USER_NOT_FOUND));
113118
String key = siteUser.getProfileImageUrl();
114119
deleteFile(key);
115120
}

0 commit comments

Comments
 (0)