Fix date_sent to Date conversion

Author: pdziewa

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [Unreleased]
+
+### Fixed
+
+- Bug with converting message's `date_sent` to `Date`
+
 ## [2.0.7](https://github.com/smsapi/smsapi-javascript-client/compare/v2.0.6...v2.0.7) - 2023-07-17
 
 ### Changed

src/modules/baseMessageModule/index.spec.ts

@@ -132,4 +132,36 @@ describe('Base message module', () => {
       expect(error.data).toEqual(errorResponse);
     }
   });
+
+  it('should properly convert date_sent to Date', async () => {
+    // given
+    const number = '500000000';
+    const message = 'someMessage';
+
+    const dateSentInSeconds = 1694509448;
+
+    const req = nock(API_URL)
+      .post('/sms.do', {
+        details: true,
+        encoding: 'utf-8',
+        format: 'json',
+        message,
+        to: number,
+      })
+      .reply(200, {
+        count: 1,
+        list: [
+          {
+            date_sent: dateSentInSeconds,
+          },
+        ],
+      });
+
+    // when
+    const res = await smsapi.sms.sendSms(number, message);
+
+    // then
+    expect(req.isDone()).toBeTruthy();
+    expect(res.list[0].dateSent.getTime() / 1000).toEqual(dateSentInSeconds);
+  });
 });

src/modules/baseMessageModule/index.ts

@@ -7,7 +7,10 @@ import snakeCase from 'lodash/snakeCase';
 
 import { BaseModule } from '../baseModule';
 import { SmsDetails } from '../sms/types/SmsDetails';
-import { MessageResponse } from '../../types/MessageResponse';
+import {
+  ApiMessageResponse,
+  MessageResponse,
+} from '../../types/MessageResponse';
 import {
   MessageError,
   MessageErrorResponse,
@@ -86,8 +89,8 @@ export class BaseMessageModule extends BaseModule {
       const formData = this.getFormDataForVmsLocalFile(body, content);
 
       const data = await this.httpClient.post<
-        MessageResponse | MessageErrorResponse,
-        MessageResponse | MessageErrorResponse
+        ApiMessageResponse | MessageErrorResponse,
+        ApiMessageResponse | MessageErrorResponse
       >(this.endpoint, formData.getBuffer(), {
         headers: formData.getHeaders(),
       });
@@ -100,8 +103,8 @@ export class BaseMessageModule extends BaseModule {
     }
 
     const data = await this.httpClient.post<
-      MessageResponse | MessageErrorResponse,
-      MessageResponse | MessageErrorResponse
+      ApiMessageResponse | MessageErrorResponse,
+      ApiMessageResponse | MessageErrorResponse
     >(this.endpoint, body);
 
     if (isMessageErrorResponseData(data)) {
@@ -204,12 +207,12 @@ export class BaseMessageModule extends BaseModule {
     });
   }
 
-  protected formatResponse(response: MessageResponse): MessageResponse {
+  protected formatResponse(response: ApiMessageResponse): MessageResponse {
     return {
       ...response,
       list: response.list.map((sms) => ({
         ...sms,
-        dateSent: new Date(sms.dateSent),
+        dateSent: new Date(sms.dateSent * 1000),
         points:
           typeof sms.points === 'string' ? parseFloat(sms.points) : sms.points,
       })),

src/types/MessageResponse.ts

@@ -1,12 +1,12 @@
 import { MessageStatus } from './MessageStatus';
 
-export interface MessageResponse {
+export interface ApiMessageResponse {
   count: number;
   list: {
     id: string;
     points: number;
     number: string;
-    dateSent: Date;
+    dateSent: number;
     submittedNumber: string;
     status: MessageStatus;
     idx: string | null;
@@ -16,3 +16,16 @@ export interface MessageResponse {
   length: number;
   parts?: number;
 }
+
+export interface MessageResponse extends Omit<ApiMessageResponse, 'list'> {
+  list: {
+    id: string;
+    points: number;
+    number: string;
+    dateSent: Date;
+    submittedNumber: string;
+    status: MessageStatus;
+    idx: string | null;
+    parts?: number;
+  }[];
+}