Further simplification and dead code removal

Author: simonroeschhso

src/programflow-visualization/README.md

@@ -13,7 +13,7 @@ The self-contained UI component that the user interacts with:
 
 ### **Panel (frontend/)**
 The VS Code extension-side host that owns the webview:
-- **visualization_panel.ts**: Creates and manages the webview panel lifecycle. Receives `reset` and `append` messages from the trace backend, posts them to the webview. Handles `highlight` and `select` messages from the webview to update editor line highlighting.
+- **visualization_panel.ts**: Creates and manages the webview panel lifecycle. Receives `reset` and `append` messages from the trace backend, posts them to the webview. Handles `highlight` messages from the webview to update editor line highlighting.
 
 ## Message Flow
 
@@ -40,7 +40,7 @@ graph TB
     panel -->|postMessage reset/append| webview
     
     webview -->|custom events| adapter["vscode-host-adapter.ts"]
-    adapter -->|postMessage highlight/select| panel
+    adapter -->|postMessage highlight| panel
     panel -->|updateLineHighlight| editor
     
     ui -->|local navigation| gen

src/programflow-visualization/frontend/visualization_panel.ts

@@ -17,7 +17,6 @@ export class VisualizationPanel {
   private readonly _context: vscode.ExtensionContext;
   private readonly _outChannel: vscode.OutputChannel;
 
-  private readonly _filePath: string;
   private readonly _fileHash: string;
 
   private readonly _tracePort: MessagePort | null;
@@ -39,7 +38,6 @@ export class VisualizationPanel {
   ) {
     this._context = context;
     this._outChannel = outChannel;
-    this._filePath = filePath;
     this._fileHash = fileHash;
     this._tracePort = tracePort;
 
@@ -88,18 +86,9 @@ export class VisualizationPanel {
 
     this._panel.webview.onDidReceiveMessage(
       async (msg) => {
-        switch (msg?.command) {
-          case "highlight":
-            if (typeof msg.filePath === "string" && typeof msg.line === "number") {
-              await this.updateLineHighlight(false, msg.filePath, msg.line);
-            }
-            break;
-          case "select":
-            if (typeof msg.filePath === "string" && typeof msg.line === "number") {
-              await this.updateLineHighlight(false, msg.filePath, msg.line);
-            }
-            break;
-        }
+        if (msg?.command !== "highlight") {return;}
+        if (typeof msg.filePath !== "string" || typeof msg.line !== "number") {return;}
+        await this.updateLineHighlight(false, msg.filePath, msg.line);
       },
       undefined,
       context.subscriptions
@@ -189,7 +178,6 @@ export class VisualizationPanel {
       command: "append",
       elem,
       complete: this._backendTrace.complete,
-      len: this._backendTrace.trace.length,
     });
   }
 

src/programflow-visualization/web/html-generator.ts

@@ -185,11 +185,11 @@ export class HTMLGenerator {
 
     private frameItem(index: number, stackElem: StackElem): string {
         return `
-            <div class="column frame-item" id="frameItem?">
-                <div class="row subtitle" id="frameItemTitle">
+            <div class="column frame-item">
+                <div class="row subtitle">
                     ${stackElem.frameName === '<module>' ? 'Global' : escapeHTML(stackElem.frameName)}
                 </div>
-                <div class="column ${index === 0 ? 'current-frame' : 'frame'}" id="frameItemSubItems">
+                <div class="column ${index === 0 ? 'current-frame' : 'frame'}">
                     ${stackElem.locals.map(namedValue => this.frameSubItem(stackElem.frameName, namedValue)).join('')}
                 </div>
             </div>

src/programflow-visualization/web/vscode-host-adapter.ts

@@ -1,6 +1,8 @@
 // Bridge messages between the VS Code host API and webview custom events
 declare const acquireVsCodeApi: undefined | (() => { postMessage: (msg: any) => void });
 
+type HighlightMsg = { command: "highlight"; filePath: string; line: number };
+
 const vscode = typeof acquireVsCodeApi === "function"
   ? acquireVsCodeApi()
   : { postMessage: (_: any) => {} };
@@ -19,12 +21,8 @@ window.addEventListener("message", (event: MessageEvent) => {
   }
 });
 
-window.addEventListener("programflow:select", (e: Event) => {
-  const ce = e as CustomEvent<any>;
-  vscode.postMessage({ command: "select", ...ce.detail });
-});
-
 window.addEventListener("programflow:highlight", (e: Event) => {
   const ce = e as CustomEvent<{ filePath: string; line: number }>;
-  vscode.postMessage({ command: "highlight", ...ce.detail });
+  const msg: HighlightMsg = { command: "highlight", ...ce.detail };
+  vscode.postMessage(msg);
 });

src/programflow-visualization/web/webview.ts

@@ -3,22 +3,16 @@ import { HTMLGenerator } from "./html-generator";
 import LinkerLine from "linkerline";
 import type { BackendTraceElem, FrontendTraceElem } from "../types";
 
-// only used to add seperate Browser navigation if not in vscode
-const isVscode = typeof (window as any).acquireVsCodeApi === "function";
-
 type ResetMsg = {
   command: "reset";
   trace: BackendTraceElem[];
   complete: boolean;
-  index?: number;
 };
 
 type AppendMsg = {
   command: "append";
   elem: BackendTraceElem;
   complete: boolean;
-  index?: number;
-  len?: number;
 };
 
 // Optional example trace format (designer mode)
@@ -83,7 +77,7 @@ function renderCurrent() {
 }
 
 function postCurrentHighlight() {
-  if (!isVscode || trace.length === 0) {
+  if (trace.length === 0) {
     return;
   }
   window.dispatchEvent(new CustomEvent("programflow:highlight", {
@@ -245,15 +239,13 @@ window.addEventListener("programflow:reset", (e: Event) => {
   const msg = (e as CustomEvent<ResetMsg>).detail;
   trace = msg.trace ?? [];
   traceComplete = !!msg.complete;
-  traceIndex = Number(msg.index ?? traceIndex);
   renderCurrent();
 });
 
 window.addEventListener("programflow:append", (e: Event) => {
   const msg = (e as CustomEvent<AppendMsg>).detail;
   trace.push(msg.elem);
   traceComplete = !!msg.complete;
-  traceIndex = Number(msg.index ?? traceIndex);
   renderCurrent();
 });
 
@@ -288,8 +280,6 @@ function setupUi() {
   // Optional: example trace mode
   const anyWin = window as any;
   const staticTrace: StaticTrace | undefined = anyWin.__PROGRAMFLOW_TRACE__;
-
-  console.log("static trace mode:", !!staticTrace?.trace, staticTrace?.trace?.length);
 
   if (staticTrace?.trace) {
     trace = staticTrace.trace;