Duplicate type cast for enum

[mtanneryd]

enumdefinitions end up having two identical type casts and the culprits seems to be in row 401 and 2806 in EF.Reverse.POCO.v3.ttinclude (v3.12.0)
FinancialSettlementType = (Marketmath.Core.DM.FinancialSettlementTypes) (Marketmath.Core.DM.FinancialSettlementTypes) 0;

[sjh37]

Does this also happen in 3.13.0 ?

[mtanneryd]

Does this also happen in 3.13.0 ?

Unfortunatly yes. In 3.13.0 I also suddenly get nullable reference types even though AllowNullStrings is set to false

[mtanneryd]

The nullable issue involves the following generated code in the db context interface:

    string? ToString(); 

   TEntity? Find<TEntity>(params object?[]? keyValues) where TEntity : class;
    ValueTask<TEntity?> FindAsync<TEntity>(object?[]? keyValues, CancellationToken cancellationToken) where TEntity : class;
    ValueTask<TEntity?> FindAsync<TEntity>(params object?[]? keyValues) where TEntity : class;
    ValueTask<object?> FindAsync(Type entityType, object?[]? keyValues, CancellationToken cancellationToken);
    ValueTask<object?> FindAsync(Type entityType, params object?[]? keyValues);
    object? Find(Type entityType, params object?[]? keyValues);

[sjh37]

There are actually two separate things in this issue, so I've handled both:

1. The nullable annotations with AllowNullStrings = false - that's the same root cause as #883 (the EF Core interface/fake-context/fake-DbSet templates hard-code string? / TEntity? / object?[]? regardless of settings, with no #nullable directive in the file). Fixed there - the generator now emits an explicit #nullable enable directive around those generated types.

2. The duplicate enum cast ((Type) (Type) 0) - the cast is prepended to a column's default value in two places: ApplyEnumTypeReplacement (for enum definitions added via Settings.AddEnumDefinitions) and MultiContextFilter.UpdateColumn (for the multi-context column EnumType setting). If a column's enum type is configured through more than one of those paths, both prepend a cast and you get the doubled (Type) (Type) 0. Both spots are now idempotent - they only prepend the cast if it isn't already present. I've added a regression test for it.

Fixed in the source; it'll be in the next release. If you want to test early, grab the latest EF.Reverse.POCO.v3.ttinclude from master branch.

[sjh37]

Will be release shortly.