Fix LimitDiffsByPathspec to handle exclusion-only pathspecs#44
Open
manato-tajiri wants to merge 1 commit into
Open
Fix LimitDiffsByPathspec to handle exclusion-only pathspecs#44manato-tajiri wants to merge 1 commit into
manato-tajiri wants to merge 1 commit into
Conversation
When only exclusion pathspecs are provided (e.g., ':!*.json'), the shouldInclude flag was initialized to false, causing all file diffs to be discarded. Fixed by initializing shouldInclude to len(includes) == 0, so that when no include pathspecs exist, all files are included by default and only removed if they match an exclusion pattern. Fixes issue where 'git who table -f -n 0 ":!*.json"' showed 0 Files and 0 Lines (+/-) data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using only exclusion pathspecs (e.g.,
git who table -f -n 0 ':!*.json'), the Files and Lines (+/-) columns show 0 values. This happens because the concurrent execution path post-filters diffs usingLimitDiffsByPathspec(), which incorrectly initializesshouldIncludetofalsewhen no include pathspecs are present.Root Cause
In
internal/git/git.go, theLimitDiffsByPathspecfunction splits pathspecs into includes and excludes. When only:!*.jsonis provided:includes = [](empty)excludes = ["*.json"]The initialization
shouldInclude := falsemeans every file diff is rejected since the loop over the emptyincludesslice never executes.Fix
Changed
shouldInclude := falsetoshouldInclude := len(includes) == 0.This ensures that when only exclusion pathspecs are provided, all files are included by default and only removed if they match an exclusion pattern. Mixed include/exclude cases continue to work as before.
Testing
rubengmurray/no-unawaited-dot-catch-throw:git who table -f -n 0 ':!*.json'now correctly shows 9 files, 568/120 lines instead of 0/0GOMAXPROCS=4) and non-concurrent (GOMAXPROCS=1) paths produce identical correct results