Skip to content

Commit 0300a7e

Browse files
committed
[Balance] fix umbral embrace not consuming ascendant fires
1 parent c5daeef commit 0300a7e

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

engine/class_modules/sc_druid.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8451,8 +8451,9 @@ struct starfire_base_t : public use_fluid_form_t<MOONKIN_FORM, ap_generator_t>
84518451
{
84528452
base_t::execute();
84538453

8454-
if ( !p()->buff.ascendant_fires->check() && p()->buff.owlkin_frenzy->up() )
8455-
p()->buff.owlkin_frenzy->expire();
8454+
if ( !p()->buff.ascendant_fires->consume( this ) )
8455+
if ( p()->buff.owlkin_frenzy->up() )
8456+
p()->buff.owlkin_frenzy->expire();
84568457

84578458
p()->buff.lunar_eclipse_override->trigger();
84588459
}
@@ -8992,6 +8993,8 @@ struct wrath_base_t : public use_fluid_form_t<MOONKIN_FORM, ap_generator_t>
89928993
{
89938994
base_t::execute();
89948995

8996+
p()->buff.ascendant_fires->consume( this );
8997+
89958998
if ( !p()->talent.lunar_calling.ok() )
89968999
p()->buff.lunar_eclipse_override->expire();
89979000
}
@@ -14174,7 +14177,7 @@ void druid_t::parse_action_effects( action_t* action )
1417414177
// and dream burst (433850) and solar bolt (1261573)
1417514178
affect_list_t( 3 ).add_label( 2391 ).add_spell( 433850 ).add_spell( 1261573 ) );
1417614179

14177-
_a->parse_effects( buff.ascendant_fires, CONSUME_BUFF );
14180+
_a->parse_effects( buff.ascendant_fires ); // consumption handled within starfire_base_t/wrath_base_t
1417814181
_a->parse_effects( buff.ascendant_stars, CONSUME_BUFF );
1417914182
_a->parse_effects( buff.astral_communion );
1418014183

0 commit comments

Comments
 (0)