Skip to content

Commit f1fd878

Browse files
waleedlatif1claude
andcommitted
fix: handle Lua nil as locked OTP and add SSRF check to MCP env resolution
- Treat Redis Lua nil return (expired/deleted key) as 'locked' instead of silently treating it as a successful increment - Add validateMcpServerSsrf to MCP service resolveConfigEnvVars so env-var URLs are SSRF-validated after resolution at execution time Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 1313265 commit f1fd878

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

apps/sim/lib/mcp/service.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { isTest } from '@/lib/core/config/feature-flags'
1010
import { generateRequestId } from '@/lib/core/utils/request'
1111
import { McpClient } from '@/lib/mcp/client'
1212
import { mcpConnectionManager } from '@/lib/mcp/connection-manager'
13-
import { isMcpDomainAllowed, validateMcpDomain } from '@/lib/mcp/domain-check'
13+
import { isMcpDomainAllowed, validateMcpDomain, validateMcpServerSsrf } from '@/lib/mcp/domain-check'
1414
import { resolveMcpConfigEnvVars } from '@/lib/mcp/resolve-config'
1515
import {
1616
createMcpCacheAdapter,
@@ -68,6 +68,7 @@ class McpService {
6868
strict: true,
6969
})
7070
validateMcpDomain(resolvedConfig.url)
71+
await validateMcpServerSsrf(resolvedConfig.url)
7172
return resolvedConfig
7273
}
7374

0 commit comments

Comments
 (0)