Skip to content

Commit c77f3e6

Browse files
committed
address comments
1 parent 32296d0 commit c77f3e6

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

docker-compose.prod.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ services:
7171
migrations:
7272
condition: service_completed_successfully
7373
healthcheck:
74-
test: ['CMD', 'wget', '--spider', '--quiet', 'http://127.0.0.1:${WORKER_PORT:-3001}/health']
74+
test: ['CMD', 'wget', '--spider', '--quiet', 'http://127.0.0.1:${WORKER_PORT:-3001}/health/live']
7575
interval: 90s
7676
timeout: 5s
7777
retries: 3

helm/sim/templates/_helpers.tpl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,10 @@ Skip validation when using existing secrets or External Secrets Operator
222222
{{- fail "realtime.env.BETTER_AUTH_SECRET must not use the default placeholder value. Generate a secure secret with: openssl rand -hex 32" }}
223223
{{- end }}
224224
{{- end }}
225+
{{- /* Worker validation - REDIS_URL is required when worker is enabled */ -}}
226+
{{- if and .Values.worker.enabled (not .Values.app.env.REDIS_URL) }}
227+
{{- fail "app.env.REDIS_URL is required when worker.enabled=true" }}
228+
{{- end }}
225229
{{- /* PostgreSQL password validation - skip if using existing secret or ESO */ -}}
226230
{{- if not (or $useExistingPostgresSecret $useExternalSecrets) }}
227231
{{- if and .Values.postgresql.enabled (not .Values.postgresql.auth.password) }}

helm/sim/templates/deployment-worker.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,11 @@ spec:
6262
value: "service.name=sim-worker,service.version={{ .Chart.AppVersion }},deployment.environment={{ .Values.worker.env.NODE_ENV }}"
6363
{{- end }}
6464
{{- range $key, $value := .Values.worker.env }}
65+
{{- if ne $key "WORKER_PORT" }}
6566
- name: {{ $key }}
6667
value: {{ $value | quote }}
6768
{{- end }}
69+
{{- end }}
6870
{{- with .Values.extraEnvVars }}
6971
{{- toYaml . | nindent 12 }}
7072
{{- end }}

0 commit comments

Comments
 (0)