fix(react): restore useEffect for help/invite modals, combobox index reset

- Help modal: restore useEffect watching `open` for form reset on
  programmatic open (same Radix onOpenChange pattern as other modals)
- Invite modal: restore useEffect watching `open` to clear error on
  programmatic open
- Combobox: restore useEffect to reset highlightedIndex when filtered
  options shrink (prevents stale index from reappearing when options grow)
- Remove no-op handleOpenChange wrappers in rename-document and
  edit-knowledge-base modals (now pure pass-throughs after useEffect fix)

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/rename-document-modal/rename-document-modal.tsx

@@ -46,11 +46,6 @@ export function RenameDocumentModal({
     }
   }, [open, initialName])
 
-  /** Resets form state when the modal opens and forwards the open state change */
-  const handleOpenChange = (newOpen: boolean) => {
-    onOpenChange(newOpen)
-  }
-
   const handleSubmit = async (e: React.FormEvent) => {
     e.preventDefault()
 
@@ -81,7 +76,7 @@ export function RenameDocumentModal({
   }
 
   return (
-    <Modal open={open} onOpenChange={handleOpenChange}>
+    <Modal open={open} onOpenChange={onOpenChange}>
       <ModalContent size='sm'>
         <ModalHeader>Rename Document</ModalHeader>
         <form onSubmit={handleSubmit} className='flex min-h-0 flex-1 flex-col'>

apps/sim/app/workspace/[workspaceId]/knowledge/components/edit-knowledge-base-modal/edit-knowledge-base-modal.tsx

@@ -81,11 +81,6 @@ export function EditKnowledgeBaseModal({
     }
   }, [open, initialName, initialDescription, reset])
 
-  /** Forwards the open state change to the parent */
-  const handleOpenChange = (newOpen: boolean) => {
-    onOpenChange(newOpen)
-  }
-
   const onSubmit = async (data: FormValues) => {
     setIsSubmitting(true)
     setError(null)
@@ -102,7 +97,7 @@ export function EditKnowledgeBaseModal({
   }
 
   return (
-    <Modal open={open} onOpenChange={handleOpenChange}>
+    <Modal open={open} onOpenChange={onOpenChange}>
       <ModalContent size='sm'>
         <ModalHeader>Edit Knowledge Base</ModalHeader>
 

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/help-modal/help-modal.tsx

@@ -103,18 +103,11 @@ export function HelpModal({ open, onOpenChange, workflowId, workspaceId }: HelpM
     })
   }, [reset])
 
-  /**
-   * Wrap onOpenChange to reset state when the modal opens
-   */
-  const handleOpenChange = useCallback(
-    (newOpen: boolean) => {
-      if (newOpen) {
-        resetModalState()
-      }
-      onOpenChange(newOpen)
-    },
-    [onOpenChange, resetModalState]
-  )
+  useEffect(() => {
+    if (open) {
+      resetModalState()
+    }
+  }, [open, resetModalState])
 
   /**
    * Fix z-index for popover/dropdown when inside modal
@@ -426,11 +419,11 @@ export function HelpModal({ open, onOpenChange, workflowId, workspaceId }: HelpM
    * Handle modal close action
    */
   const handleClose = useCallback(() => {
-    handleOpenChange(false)
-  }, [handleOpenChange])
+    onOpenChange(false)
+  }, [onOpenChange])
 
   return (
-    <Modal open={open} onOpenChange={handleOpenChange}>
+    <Modal open={open} onOpenChange={onOpenChange}>
       <ModalContent size='md'>
         <ModalHeader>Help &amp; Support</ModalHeader>
 

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/components/invite-modal/invite-modal.tsx

@@ -85,6 +85,12 @@ export function InviteModal({ open, onOpenChange, workspaceName }: InviteModalPr
   const isRemovingMember = removeMember.isPending
   const isRemovingInvitation = cancelInvitation.isPending
 
+  useEffect(() => {
+    if (open) {
+      setErrorMessage(null)
+    }
+  }, [open])
+
   useEffect(() => {
     const intervalsRef = cooldownIntervalsRef.current
     return () => {
@@ -459,9 +465,7 @@ export function InviteModal({ open, onOpenChange, workspaceName }: InviteModalPr
     <Modal
       open={open}
       onOpenChange={(newOpen: boolean) => {
-        if (newOpen) {
-          setErrorMessage(null)
-        } else {
+        if (!newOpen) {
           resetState()
         }
         onOpenChange(newOpen)

apps/sim/components/emcn/components/combobox/combobox.tsx

@@ -465,6 +465,15 @@ const Combobox = memo(
       const effectiveHighlightedIndex =
         highlightedIndex >= 0 && highlightedIndex < filteredOptions.length ? highlightedIndex : -1
 
+      /**
+       * Reset highlighted index when filtered options shrink below it
+       */
+      useEffect(() => {
+        if (highlightedIndex >= 0 && highlightedIndex >= filteredOptions.length) {
+          setHighlightedIndex(-1)
+        }
+      }, [filteredOptions.length, highlightedIndex])
+
       /**
        * Scroll highlighted option into view
        */