Skip to content

Commit bc2401f

Browse files
chore: address review comments
1 parent 7cdd19e commit bc2401f

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

apps/sim/components/emcn/components/button/button.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const buttonVariants = cva(
2424
ghost: 'text-[var(--text-secondary)] hover-hover:text-[var(--text-primary)]',
2525
subtle:
2626
'text-[var(--text-body)] hover-hover:text-[var(--text-body)] hover-hover:bg-[var(--surface-4)]',
27-
'ghost-secondary': 'text-[var(--text-muted)]',
27+
'ghost-secondary': 'text-[var(--text-muted)] hover-hover:text-[var(--text-primary)]',
2828
/** Branded button - requires branded-button-gradient or branded-button-custom class for colors */
2929
branded:
3030
'rounded-[10px] border text-white hover-hover:text-white text-base transition-[transform,background-color,color,border-color] duration-200',

apps/sim/components/emcn/components/popover/popover.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,16 @@ const PopoverContent = React.forwardRef<
630630
...style,
631631
}}
632632
>
633-
{children}
633+
{showArrow ? (
634+
<div
635+
className='overflow-auto flex-1 flex flex-col'
636+
style={{ maxHeight: `${maxHeight || 400}px` }}
637+
>
638+
{children}
639+
</div>
640+
) : (
641+
children
642+
)}
634643
{showArrow && (
635644
<PopoverPrimitive.Arrow width={14} height={7} asChild>
636645
<svg
@@ -1203,4 +1212,4 @@ export {
12031212
usePopoverContext,
12041213
}
12051214

1206-
export type { PopoverSize, PopoverColorScheme }
1215+
export type { PopoverSize, PopoverColorScheme }

0 commit comments

Comments
 (0)