fix(editor): avoid stale open-change fetch gating

Danigm-dev · Danigm-dev · commit a27de0d7c67d · 2026-03-25T17:10:02.000+01:00
diff --git a/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/combobox/combobox.tsx b/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/combobox/combobox.tsx
@@ -453,11 +453,11 @@ export const ComboBox = memo(function ComboBox({
    */
   const handleOpenChange = useCallback(
     (open: boolean) => {
-      if (open && (fetchedOptions.length === 0 || fetchError !== null)) {
+      if (open) {
         void fetchOptionsIfNeeded(fetchError !== null)
       }
     },
-    [fetchError, fetchOptionsIfNeeded, fetchedOptions.length]
+    [fetchError, fetchOptionsIfNeeded]
   )
 
   /**
diff --git a/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/dropdown/dropdown.tsx b/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/dropdown/dropdown.tsx
@@ -196,11 +196,11 @@ export const Dropdown = memo(function Dropdown({
    */
   const handleOpenChange = useCallback(
     (open: boolean) => {
-      if (open && (fetchedOptions.length === 0 || fetchError !== null)) {
+      if (open) {
         void fetchOptionsIfNeeded(fetchError !== null)
       }
     },
-    [fetchError, fetchOptionsIfNeeded, fetchedOptions.length]
+    [fetchError, fetchOptionsIfNeeded]
   )
 
   const evaluatedOptions = useMemo(() => {

Original file line number	Diff line number	Diff line change
`@@ -453,11 +453,11 @@ export const ComboBox = memo(function ComboBox({`
`453`	`453`	`*/`
`454`	`454`	`const handleOpenChange = useCallback(`
`455`	`455`	`(open: boolean) => {`
`456`		`- if (open && (fetchedOptions.length === 0 \|\| fetchError !== null)) {`
	`456`	`+ if (open) {`
`457`	`457`	`void fetchOptionsIfNeeded(fetchError !== null)`
`458`	`458`	`}`
`459`	`459`	`},`
`460`		`- [fetchError, fetchOptionsIfNeeded, fetchedOptions.length]`
	`460`	`+ [fetchError, fetchOptionsIfNeeded]`
`461`	`461`	`)`
`462`	`462`
`463`	`463`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -196,11 +196,11 @@ export const Dropdown = memo(function Dropdown({`
`196`	`196`	`*/`
`197`	`197`	`const handleOpenChange = useCallback(`
`198`	`198`	`(open: boolean) => {`
`199`		`- if (open && (fetchedOptions.length === 0 \|\| fetchError !== null)) {`
	`199`	`+ if (open) {`
`200`	`200`	`void fetchOptionsIfNeeded(fetchError !== null)`
`201`	`201`	`}`
`202`	`202`	`},`
`203`		`- [fetchError, fetchOptionsIfNeeded, fetchedOptions.length]`
	`203`	`+ [fetchError, fetchOptionsIfNeeded]`
`204`	`204`	`)`
`205`	`205`
`206`	`206`	`const evaluatedOptions = useMemo(() => {`