fix(uploads): require workspace write+ for execution presigned, admin-only for workspace-logos, suppress doubled error toast

Author: waleedlatif1

apps/sim/app/api/files/presigned/route.ts

@@ -167,6 +167,14 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
         )
       }
 
+      const permission = await getUserEntityPermissions(sessionUserId, 'workspace', workspaceId)
+      if (permission !== 'write' && permission !== 'admin') {
+        return NextResponse.json(
+          { error: 'Write or Admin access required for execution uploads' },
+          { status: 403 }
+        )
+      }
+
       const fileValidationError = validateFileType(fileName, contentType)
       if (fileValidationError) {
         throw new ValidationError(fileValidationError.message)
@@ -192,9 +200,9 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
       }
 
       const permission = await getUserEntityPermissions(sessionUserId, 'workspace', workspaceId)
-      if (permission !== 'write' && permission !== 'admin') {
+      if (permission !== 'admin') {
         return NextResponse.json(
-          { error: 'Write or Admin access required for workspace logo uploads' },
+          { error: 'Admin access required for workspace logo uploads' },
           { status: 403 }
         )
       }

apps/sim/hooks/queries/workspace-files.ts

@@ -331,9 +331,11 @@ export function useUploadWorkspaceFile() {
     },
     onError: (error, variables) => {
       logger.error('Failed to upload file:', error)
-      toast.error(`Failed to upload "${variables.file.name}": ${error.message}`, {
-        duration: 5000,
-      })
+      if (!variables.skipToast) {
+        toast.error(`Failed to upload "${variables.file.name}": ${error.message}`, {
+          duration: 5000,
+        })
+      }
     },
   })
 }