chore(auth): add comment explaining why safeCallbackUrl skip re-validation

waleedlatif1 · waleedlatif1 · commit 8412f4201420 · 2026-03-19T13:56:16.000-07:00
diff --git a/apps/sim/app/(auth)/login/login-form.tsx b/apps/sim/app/(auth)/login/login-form.tsx
@@ -175,6 +175,7 @@ export default function LoginPage({
     }
 
     try {
+      // callbackUrl is already validated at initialization — either a passing callbackUrlParam or '/workspace'
       const safeCallbackUrl = callbackUrl
       let errorHandled = false
 
diff --git a/apps/sim/ee/sso/components/sso-form.tsx b/apps/sim/ee/sso/components/sso-form.tsx
@@ -98,6 +98,7 @@ export default function SSOForm() {
     }
 
     try {
+      // callbackUrl is already validated at initialization — either a passing callbackUrlParam or '/workspace'
       const safeCallbackUrl = callbackUrl
 
       await client.signIn.sso({

Original file line number	Diff line number	Diff line change
`@@ -175,6 +175,7 @@ export default function LoginPage({`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`try {`
	`178`	`+ // callbackUrl is already validated at initialization — either a passing callbackUrlParam or '/workspace'`
`178`	`179`	`const safeCallbackUrl = callbackUrl`
`179`	`180`	`let errorHandled = false`
`180`	`181`
Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,7 @@ export default function SSOForm() {`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`try {`
	`101`	`+ // callbackUrl is already validated at initialization — either a passing callbackUrlParam or '/workspace'`
`101`	`102`	`const safeCallbackUrl = callbackUrl`
`102`	`103`
`103`	`104`	`await client.signIn.sso({`