fix(tour): address PR review comments

- Move autoStartAttempted.add() inside timer callback to prevent
  blocking auto-start when tour first mounts while disabled
- Memoize setJoyrideRef with useCallback to prevent ref churn
- Remove unused joyrideRef

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/components/product-tour/tour-shared.tsx

@@ -1,6 +1,6 @@
 'use client'
 
-import { createContext, useContext, useEffect, useRef, useState } from 'react'
+import { createContext, useCallback, useContext, useEffect, useState } from 'react'
 import type { TooltipRenderProps } from 'react-joyride'
 import { TourTooltip } from '@/components/emcn'
 
@@ -60,7 +60,6 @@ export function TourTooltipAdapter({
 }: TooltipRenderProps) {
   const { isTooltipVisible, isEntrance, totalSteps } = useContext(TourStateContext)
   const [targetEl, setTargetEl] = useState<HTMLElement | null>(null)
-  const joyrideRef = useRef<HTMLDivElement | null>(null)
 
   useEffect(() => {
     const { target } = step
@@ -76,17 +75,21 @@ export function TourTooltipAdapter({
   /**
    * Forwards the Joyride tooltip ref safely, handling both
    * callback refs and RefObject refs from the library.
+   * Memoized to prevent ref churn (null → node cycling) on re-renders.
    */
-  const setJoyrideRef = (node: HTMLDivElement | null) => {
-    joyrideRef.current = node
-    const { ref } = tooltipProps
-    if (!ref) return
-    if (typeof ref === 'function') {
-      ref(node)
-    } else {
-      ;(ref as React.MutableRefObject<HTMLDivElement | null>).current = node
-    }
-  }
+  const setJoyrideRef = useCallback(
+    (node: HTMLDivElement | null) => {
+      const { ref } = tooltipProps
+      if (!ref) return
+      if (typeof ref === 'function') {
+        ref(node)
+      } else {
+        ;(ref as React.MutableRefObject<HTMLDivElement | null>).current = node
+      }
+    },
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    [tooltipProps.ref]
+  )
 
   const placement = mapPlacement(step.placement)
 

apps/sim/app/workspace/[workspaceId]/components/product-tour/use-tour.ts

@@ -174,12 +174,12 @@ export function useTour({
 
   /** Auto-start on first visit (once per page session per tour) */
   useEffect(() => {
-    if (autoStartAttempted.has(storageKey)) return
-    autoStartAttempted.add(storageKey)
+    if (disabled || autoStartAttempted.has(storageKey) || isTourCompleted(storageKey)) return
 
     const timer = setTimeout(() => {
-      if (disabledRef.current || isTourCompleted(storageKey)) return
+      if (disabledRef.current) return
 
+      autoStartAttempted.add(storageKey)
       setStepIndex(0)
       setIsEntrance(true)
       setIsTooltipVisible(false)
@@ -189,8 +189,7 @@ export function useTour({
     }, autoStartDelay)
 
     return () => clearTimeout(timer)
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [])
+  }, [disabled, storageKey, autoStartDelay, tourName, scheduleReveal])
 
   /** Listen for manual trigger events */
   useEffect(() => {