tool inp edge case

Author: icecrasher321

apps/sim/lib/workflows/comparison/normalize.ts

@@ -5,6 +5,7 @@
 
 import type { Edge } from 'reactflow'
 import { isNonEmptyValue } from '@/lib/workflows/subblocks/visibility'
+import { isSyntheticToolSubBlockId } from '@/lib/workflows/tool-input/synthetic-subblocks'
 import type {
   BlockState,
   Loop,
@@ -410,13 +411,6 @@ export function extractBlockFieldsForComparison(block: BlockState): ExtractedBlo
   }
 }
 
-/**
- * Pattern matching synthetic subBlock IDs created by ToolSubBlockRenderer.
- * These IDs follow the format `{subBlockId}-tool-{index}-{paramId}` and are
- * mirrors of values already stored in toolConfig.value.tools[N].params.
- */
-const SYNTHETIC_TOOL_SUBBLOCK_RE = /-tool-\d+-/
-
 /**
  * Filters subBlock IDs to exclude system, trigger runtime, and synthetic tool subBlocks.
  *
@@ -429,7 +423,7 @@ export function filterSubBlockIds(subBlockIds: string[]): string[] {
       if (TRIGGER_RUNTIME_SUBBLOCK_IDS.includes(id)) return false
       if (SYSTEM_SUBBLOCK_IDS.some((sysId) => id === sysId || id.startsWith(`${sysId}_`)))
         return false
-      if (SYNTHETIC_TOOL_SUBBLOCK_RE.test(id)) return false
+      if (isSyntheticToolSubBlockId(id)) return false
       return true
     })
     .sort()

apps/sim/lib/workflows/search-replace/indexer.test.ts

@@ -786,6 +786,59 @@ describe('indexWorkflowSearchMatches', () => {
     )
   })
 
+  it('does not double index synthetic tool-input mirror subblocks', () => {
+    const workflow = createSearchReplaceWorkflowFixture()
+    workflow.blocks['tool-input-1'] = {
+      id: 'tool-input-1',
+      type: 'custom',
+      name: 'Tool Input Block',
+      position: { x: 0, y: 0 },
+      enabled: true,
+      outputs: {},
+      subBlocks: {
+        tools: {
+          id: 'tools',
+          type: 'tool-input',
+          value: [
+            {
+              type: 'api',
+              toolId: 'http_request',
+              title: 'API',
+              params: {
+                url: 'Lmfap',
+              },
+            },
+          ],
+        },
+        'tools-tool-0-url': {
+          id: 'tools-tool-0-url',
+          type: 'short-input',
+          value: 'Lmfap',
+        },
+      },
+    }
+
+    const matches = indexWorkflowSearchMatches({
+      workflow,
+      query: 'lmf',
+      mode: 'text',
+      blockConfigs: {
+        ...SEARCH_REPLACE_BLOCK_CONFIGS,
+        custom: {
+          subBlocks: [{ id: 'tools', title: 'Tools', type: 'tool-input' }],
+        },
+      },
+    }).filter((match) => match.blockId === 'tool-input-1')
+
+    expect(matches).toEqual([
+      expect.objectContaining({
+        subBlockId: 'tools',
+        valuePath: [0, 'params', 'url'],
+        searchText: 'Lmfap',
+      }),
+    ])
+  })
+
   it('attaches selector context to selector-backed tool input params', () => {
     const workflow = createSearchReplaceWorkflowFixture()
     workflow.blocks['tool-input-1'] = {

apps/sim/lib/workflows/search-replace/indexer.ts

@@ -35,6 +35,7 @@ import {
   resolveCanonicalMode,
   resolveDependencyValue,
 } from '@/lib/workflows/subblocks/visibility'
+import { isSyntheticToolSubBlockId } from '@/lib/workflows/tool-input/synthetic-subblocks'
 import { parseStoredToolInputValue, type StoredTool } from '@/lib/workflows/tool-input/types'
 import { getBlock } from '@/blocks/registry'
 import type { SubBlockConfig } from '@/blocks/types'
@@ -945,6 +946,7 @@ export function indexWorkflowSearchMatches(
     }
 
     for (const [subBlockId, subBlockState] of Object.entries(block.subBlocks ?? {})) {
+      if (isSyntheticToolSubBlockId(subBlockId)) continue
       const subBlockConfig = configsById.get(subBlockId)
       if (subBlockConfig?.hidden) continue
       if (subBlockConfig && !isSubBlockFeatureEnabled(subBlockConfig)) continue

apps/sim/lib/workflows/tool-input/synthetic-subblocks.ts

@@ -0,0 +1,11 @@
+const SYNTHETIC_TOOL_SUBBLOCK_RE = /-tool-\d+-/
+
+/**
+ * Returns true for ToolSubBlockRenderer mirror subblocks.
+ *
+ * These IDs follow `{subBlockId}-tool-{index}-{paramId}` and duplicate values
+ * already stored in the aggregate `tool-input` subblock.
+ */
+export function isSyntheticToolSubBlockId(subBlockId: string): boolean {
+  return SYNTHETIC_TOOL_SUBBLOCK_RE.test(subBlockId)
+}