Skip to content

Commit 43a8785

Browse files
committed
fix(helm): remove duplicate nodeSelector, add hook for CA issuer ordering
1 parent 549edba commit 43a8785

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

helm/sim/templates/cert-manager-issuers.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,17 @@ spec:
6969
# 3. CA ClusterIssuer
7070
# This is the issuer that should be used by applications to obtain certificates.
7171
# It signs certificates using the root CA created above.
72+
# Uses post-install hook to ensure Certificate is ready before this issuer is created.
7273
apiVersion: cert-manager.io/v1
7374
kind: ClusterIssuer
7475
metadata:
7576
name: {{ .Values.certManager.caIssuer.name }}
7677
labels:
7778
{{- include "sim.labels" . | nindent 4 }}
7879
app.kubernetes.io/component: cert-manager
80+
annotations:
81+
"helm.sh/hook": post-install,post-upgrade
82+
"helm.sh/hook-weight": "1"
7983
spec:
8084
ca:
8185
secretName: {{ .Values.certManager.rootCA.secretName }}

helm/sim/templates/gpu-device-plugin.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,4 @@ spec:
112112
limits:
113113
cpu: 50m
114114
memory: 50Mi
115-
{{- if .Values.nodeSelector }}
116-
nodeSelector:
117-
{{- toYaml .Values.nodeSelector | nindent 8 }}
118-
{{- end }}
119115
{{- end }}

0 commit comments

Comments
 (0)