Skip to content

Commit 218a492

Browse files
committed
remove unnecessary helpers, cleanup
1 parent d8ec96a commit 218a492

File tree

5 files changed

+70
-289
lines changed

5 files changed

+70
-289
lines changed

apps/sim/blocks/blocks/api.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,9 @@ Example:
9393
id: 'retries',
9494
title: 'Retries',
9595
type: 'short-input',
96-
placeholder: '2',
96+
placeholder: '0',
9797
description:
98-
'Number of retry attempts for timeouts, 429 responses, and 5xx errors (default: 2 for GET/PUT/DELETE/HEAD)',
98+
'Number of retry attempts for timeouts, 429 responses, and 5xx errors (default: 0, no retries)',
9999
mode: 'advanced',
100100
},
101101
{

apps/sim/tools/http/request.ts

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -55,23 +55,23 @@ export const requestTool: ToolConfig<RequestParams, RequestResponse> = {
5555
},
5656
retries: {
5757
type: 'number',
58-
visibility: 'user-only',
58+
visibility: 'hidden',
5959
description:
6060
'Number of retry attempts for retryable failures (timeouts, 429, 5xx). Defaults to 2 for idempotent methods (GET/PUT/DELETE/HEAD) and 0 otherwise.',
6161
},
6262
retryDelayMs: {
6363
type: 'number',
64-
visibility: 'user-only',
64+
visibility: 'hidden',
6565
description: 'Initial retry delay in milliseconds (default: 500)',
6666
},
6767
retryMaxDelayMs: {
6868
type: 'number',
69-
visibility: 'user-only',
69+
visibility: 'hidden',
7070
description: 'Maximum delay between retries in milliseconds (default: 30000)',
7171
},
7272
retryNonIdempotent: {
7373
type: 'boolean',
74-
visibility: 'user-only',
74+
visibility: 'hidden',
7575
description:
7676
'Allow retries for non-idempotent methods like POST/PATCH (may create duplicate requests).',
7777
},
@@ -144,22 +144,10 @@ export const requestTool: ToolConfig<RequestParams, RequestResponse> = {
144144

145145
retry: {
146146
enabled: true,
147-
maxRetries: 2,
148-
maxRetriesLimit: 10,
147+
maxRetries: 0,
149148
initialDelayMs: 500,
150149
maxDelayMs: 30000,
151-
retryOnStatusCodes: [429],
152-
retryOnStatusRanges: [{ min: 500, max: 599 }],
153-
retryOnTimeout: true,
154-
retryOnNetworkError: true,
155-
respectRetryAfter: true,
156-
retryableMethods: ['GET', 'HEAD', 'PUT', 'DELETE'],
157-
paramOverrides: {
158-
retries: 'retries',
159-
initialDelayMs: 'retryDelayMs',
160-
maxDelayMs: 'retryMaxDelayMs',
161-
nonIdempotent: 'retryNonIdempotent',
162-
},
150+
retryIdempotentOnly: true,
163151
},
164152
},
165153

apps/sim/tools/index.test.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1000,6 +1000,21 @@ describe('MCP Tool Execution', () => {
10001000
expect((result.output as any).status).toBe(200)
10011001
})
10021002

1003+
it('does not retry when retries is not specified (default: 0)', async () => {
1004+
global.fetch = Object.assign(
1005+
vi.fn().mockResolvedValue(makeJsonResponse(500, { error: 'server error' })),
1006+
{ preconnect: vi.fn() }
1007+
) as typeof fetch
1008+
1009+
const result = await executeTool('http_request', {
1010+
url: '/api/test',
1011+
method: 'GET',
1012+
})
1013+
1014+
expect(global.fetch).toHaveBeenCalledTimes(1)
1015+
expect(result.success).toBe(false)
1016+
})
1017+
10031018
it('stops retrying after max attempts for http_request', async () => {
10041019
global.fetch = Object.assign(
10051020
vi.fn().mockResolvedValue(makeJsonResponse(502, { error: 'bad gateway' })),

0 commit comments

Comments
 (0)