fix: remove stale socket operation branches

Author: PlaneInABottle

apps/sim/socket/handlers/operations.test.ts

@@ -992,4 +992,97 @@ describe('setupOperationsHandlers', () => {
       expect.objectContaining({ operationId: 'op-2', serverTimestamp: expect.any(Number) })
     )
   })
+
+  it('broadcasts valid block toggle operations through the default handler', async () => {
+    mockPersistWorkflowOperation.mockResolvedValue({})
+
+    const socketEmit = vi.fn()
+    const socketRoomEmit = vi.fn()
+    const emitToWorkflow = vi.fn()
+    const socketHandlers = new Map<string, (data: unknown) => Promise<void>>()
+
+    const socket = {
+      id: 'socket-1',
+      on: vi.fn((event: string, handler: (data: unknown) => Promise<void>) => {
+        socketHandlers.set(event, handler)
+      }),
+      emit: socketEmit,
+      to: vi.fn(() => ({
+        emit: socketRoomEmit,
+      })),
+    }
+
+    const roomManager = {
+      io: {} as never,
+      initialize: vi.fn(),
+      isReady: vi.fn(() => true),
+      shutdown: vi.fn(),
+      addUserToRoom: vi.fn(),
+      removeUserFromRoom: vi.fn(),
+      getWorkflowIdForSocket: vi.fn().mockResolvedValue('workflow-1'),
+      getUserSession: vi.fn().mockResolvedValue({ userId: 'user-1', userName: 'Test User' }),
+      getWorkflowUsers: vi.fn().mockResolvedValue([
+        {
+          socketId: 'socket-1',
+          userId: 'user-1',
+          workflowId: 'workflow-1',
+          userName: 'Test User',
+          joinedAt: Date.now(),
+          lastActivity: Date.now(),
+          role: 'admin',
+        },
+      ]),
+      hasWorkflowRoom: vi.fn().mockResolvedValue(true),
+      updateUserActivity: vi.fn(),
+      updateRoomLastModified: vi.fn(),
+      broadcastPresenceUpdate: vi.fn(),
+      emitToWorkflow,
+      getUniqueUserCount: vi.fn(),
+      getTotalActiveConnections: vi.fn(),
+      handleWorkflowDeletion: vi.fn(),
+      handleWorkflowRevert: vi.fn(),
+      handleWorkflowUpdate: vi.fn(),
+    }
+
+    setupOperationsHandlers(socket as never, roomManager)
+
+    const workflowOperationHandler = socketHandlers.get('workflow-operation')
+
+    await workflowOperationHandler?.({
+      operationId: 'op-toggle-enabled',
+      operation: BLOCK_OPERATIONS.TOGGLE_ENABLED,
+      target: OPERATION_TARGETS.BLOCK,
+      payload: {
+        id: 'block-1',
+        enabled: false,
+      },
+      timestamp: 789,
+    })
+
+    expect(mockPersistWorkflowOperation).toHaveBeenCalledWith(
+      'workflow-1',
+      expect.objectContaining({
+        operation: BLOCK_OPERATIONS.TOGGLE_ENABLED,
+        target: OPERATION_TARGETS.BLOCK,
+        payload: { id: 'block-1', enabled: false },
+        userId: 'user-1',
+      })
+    )
+    expect(socketRoomEmit).toHaveBeenCalledWith(
+      'workflow-operation',
+      expect.objectContaining({
+        operation: BLOCK_OPERATIONS.TOGGLE_ENABLED,
+        target: OPERATION_TARGETS.BLOCK,
+        payload: { id: 'block-1', enabled: false },
+      })
+    )
+    expect(emitToWorkflow).not.toHaveBeenCalled()
+    expect(socketEmit).toHaveBeenCalledWith(
+      'operation-confirmed',
+      expect.objectContaining({
+        operationId: 'op-toggle-enabled',
+        serverTimestamp: expect.any(Number),
+      })
+    )
+  })
 })

apps/sim/socket/handlers/operations.ts

@@ -684,70 +684,6 @@ export function setupOperationsHandlers(socket: AuthenticatedSocket, roomManager
         return
       }
 
-      if (target === OPERATION_TARGETS.VARIABLE && operation === VARIABLE_OPERATIONS.UPDATE) {
-        await persistWorkflowOperation(workflowId, {
-          operation,
-          target,
-          payload,
-          timestamp: operationTimestamp,
-          userId: session.userId,
-        })
-
-        await roomManager.updateRoomLastModified(workflowId)
-
-        socket.to(workflowId).emit('workflow-operation', {
-          operation,
-          target,
-          payload,
-          timestamp: operationTimestamp,
-          senderId: socket.id,
-          userId: session.userId,
-          userName: session.userName,
-          metadata: { workflowId, operationId: crypto.randomUUID() },
-        })
-
-        if (operationId) {
-          socket.emit('operation-confirmed', {
-            operationId,
-            serverTimestamp: Date.now(),
-          })
-        }
-
-        return
-      }
-
-      if (target === OPERATION_TARGETS.BLOCK && operation === BLOCK_OPERATIONS.UPDATE_METADATA) {
-        await persistWorkflowOperation(workflowId, {
-          operation,
-          target,
-          payload,
-          timestamp: operationTimestamp,
-          userId: session.userId,
-        })
-
-        await roomManager.updateRoomLastModified(workflowId)
-
-        socket.to(workflowId).emit('workflow-operation', {
-          operation,
-          target,
-          payload,
-          timestamp: operationTimestamp,
-          senderId: socket.id,
-          userId: session.userId,
-          userName: session.userName,
-          metadata: { workflowId, operationId: crypto.randomUUID() },
-        })
-
-        if (operationId) {
-          socket.emit('operation-confirmed', {
-            operationId,
-            serverTimestamp: Date.now(),
-          })
-        }
-
-        return
-      }
-
       if (target === OPERATION_TARGETS.BLOCK && operation === BLOCK_OPERATIONS.UPDATE_NAME) {
         await persistWorkflowOperation(workflowId, {
           operation,
@@ -780,38 +716,6 @@ export function setupOperationsHandlers(socket: AuthenticatedSocket, roomManager
         return
       }
 
-      if (target === OPERATION_TARGETS.BLOCK && operation === BLOCK_OPERATIONS.UPDATE_SUBBLOCK) {
-        await persistWorkflowOperation(workflowId, {
-          operation,
-          target,
-          payload,
-          timestamp: operationTimestamp,
-          userId: session.userId,
-        })
-
-        await roomManager.updateRoomLastModified(workflowId)
-
-        socket.to(workflowId).emit('workflow-operation', {
-          operation,
-          target,
-          payload,
-          timestamp: operationTimestamp,
-          senderId: socket.id,
-          userId: session.userId,
-          userName: session.userName,
-          metadata: { workflowId, operationId: crypto.randomUUID() },
-        })
-
-        if (operationId) {
-          socket.emit('operation-confirmed', {
-            operationId,
-            serverTimestamp: Date.now(),
-          })
-        }
-
-        return
-      }
-
       // Default handler for simple persistence and broadcast
       await persistWorkflowOperation(workflowId, {
         operation,