Fix orphaned loop-in-loop if parent id not found

Author: Theodore Li

apps/sim/lib/copilot/tools/server/workflow/edit-workflow/operations.test.ts

@@ -408,4 +408,42 @@ describe('handleEditOperation nestedNodes merge', () => {
     const helperBlock = Object.values(state.blocks).find((block: any) => block.name === 'Helper')
     expect(helperBlock).toBeDefined()
   })
+
+  it('removes an unmatched nested container with all descendants and edges', () => {
+    const workflow = makeNestedLoopWorkflow()
+
+    const { state } = applyOperationsToWorkflowState(workflow, [
+      {
+        operation_type: 'edit',
+        block_id: 'outer-loop',
+        params: {
+          nestedNodes: {
+            replacement: {
+              type: 'function',
+              name: 'Replacement',
+              inputs: { code: 'return 2' },
+            },
+          },
+        },
+      },
+    ])
+
+    expect(state.blocks['inner-loop']).toBeUndefined()
+    expect(state.blocks['inner-agent']).toBeUndefined()
+    expect(
+      state.edges.some(
+        (edge: any) =>
+          edge.source === 'inner-loop' ||
+          edge.target === 'inner-loop' ||
+          edge.source === 'inner-agent' ||
+          edge.target === 'inner-agent'
+      )
+    ).toBe(false)
+
+    const replacementBlock = Object.values(state.blocks).find(
+      (block: any) => block.name === 'Replacement'
+    ) as any
+    expect(replacementBlock).toBeDefined()
+    expect(replacementBlock.data?.parentId).toBe('outer-loop')
+  })
 })

apps/sim/lib/copilot/tools/server/workflow/edit-workflow/operations.ts

@@ -297,11 +297,27 @@ function mergeNestedNodesForParent(
     }
   })
 
+  const collectBlockAndDescendants = (
+    rootId: string,
+    collected = new Set<string>()
+  ): Set<string> => {
+    collected.add(rootId)
+    Object.entries(modifiedState.blocks).forEach(([childId, block]: [string, any]) => {
+      if (block.data?.parentId === rootId && !collected.has(childId)) {
+        collectBlockAndDescendants(childId, collected)
+      }
+    })
+    return collected
+  }
+
   const removedIds = new Set<string>()
   for (const [existingId] of existingChildren) {
     if (!matchedExistingIds.has(existingId)) {
-      delete modifiedState.blocks[existingId]
-      removedIds.add(existingId)
+      const subtreeIds = collectBlockAndDescendants(existingId)
+      subtreeIds.forEach((id) => {
+        delete modifiedState.blocks[id]
+        removedIds.add(id)
+      })
     }
   }