Use established pattern for error handling

Author: Theodore Li

apps/sim/app/api/knowledge/[id]/route.ts

@@ -5,10 +5,10 @@ import { AuditAction, AuditResourceType, recordAudit } from '@/lib/audit/log'
 import { checkSessionOrInternalAuth } from '@/lib/auth/hybrid'
 import { PlatformEvents } from '@/lib/core/telemetry'
 import { generateRequestId } from '@/lib/core/utils/request'
-import { DuplicateNameError } from '@/lib/core/errors'
 import {
   deleteKnowledgeBase,
   getKnowledgeBaseById,
+  KnowledgeBaseConflictError,
   updateKnowledgeBase,
 } from '@/lib/knowledge/service'
 import { checkKnowledgeBaseAccess, checkKnowledgeBaseWriteAccess } from '@/app/api/knowledge/utils'
@@ -167,7 +167,7 @@ export async function PUT(req: NextRequest, { params }: { params: Promise<{ id:
       throw validationError
     }
   } catch (error) {
-    if (error instanceof DuplicateNameError) {
+    if (error instanceof KnowledgeBaseConflictError) {
       return NextResponse.json({ error: error.message }, { status: 409 })
     }
 

apps/sim/app/api/knowledge/route.ts

@@ -5,10 +5,10 @@ import { AuditAction, AuditResourceType, recordAudit } from '@/lib/audit/log'
 import { getSession } from '@/lib/auth'
 import { PlatformEvents } from '@/lib/core/telemetry'
 import { generateRequestId } from '@/lib/core/utils/request'
-import { DuplicateNameError } from '@/lib/core/errors'
 import {
   createKnowledgeBase,
   getKnowledgeBases,
+  KnowledgeBaseConflictError,
   type KnowledgeBaseScope,
 } from '@/lib/knowledge/service'
 
@@ -150,7 +150,7 @@ export async function POST(req: NextRequest) {
       throw validationError
     }
   } catch (error) {
-    if (error instanceof DuplicateNameError) {
+    if (error instanceof KnowledgeBaseConflictError) {
       return NextResponse.json({ error: error.message }, { status: 409 })
     }
 

apps/sim/app/api/table/[tableId]/route.ts

@@ -3,8 +3,14 @@ import { type NextRequest, NextResponse } from 'next/server'
 import { z } from 'zod'
 import { checkSessionOrInternalAuth } from '@/lib/auth/hybrid'
 import { generateRequestId } from '@/lib/core/utils/request'
-import { DuplicateNameError } from '@/lib/core/errors'
-import { deleteTable, NAME_PATTERN, renameTable, TABLE_LIMITS, type TableSchema } from '@/lib/table'
+import {
+  deleteTable,
+  NAME_PATTERN,
+  renameTable,
+  TABLE_LIMITS,
+  TableConflictError,
+  type TableSchema,
+} from '@/lib/table'
 import { accessError, checkAccess, normalizeColumn } from '@/app/api/table/utils'
 
 const logger = createLogger('TableDetailAPI')
@@ -137,7 +143,7 @@ export async function PATCH(request: NextRequest, { params }: TableRouteParams)
       )
     }
 
-    if (error instanceof DuplicateNameError) {
+    if (error instanceof TableConflictError) {
       return NextResponse.json({ error: error.message }, { status: 409 })
     }
 

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/notifications/notifications.tsx

@@ -2,6 +2,7 @@ import { memo, useCallback, useEffect, useMemo, useRef, useState } from 'react'
 import { createLogger } from '@sim/logger'
 import { X } from 'lucide-react'
 import { Button, Tooltip } from '@/components/emcn'
+import { CountdownRing } from '@/components/emcn/components/toast/countdown-ring'
 import { useRegisterGlobalCommands } from '@/app/workspace/[workspaceId]/providers/global-commands-provider'
 import { createCommands } from '@/app/workspace/[workspaceId]/utils/commands-utils'
 import { usePreventZoom } from '@/app/workspace/[workspaceId]/w/[workflowId]/hooks'
@@ -20,9 +21,6 @@ const STACK_OFFSET_PX = 3
 const AUTO_DISMISS_MS = 10000
 const EXIT_ANIMATION_MS = 200
 
-const RING_RADIUS = 5.5
-const RING_CIRCUMFERENCE = 2 * Math.PI * RING_RADIUS
-
 const ACTION_LABELS: Record<NotificationAction['type'], string> = {
   copilot: 'Fix in Copilot',
   refresh: 'Refresh',
@@ -33,38 +31,17 @@ function isAutoDismissable(n: Notification): boolean {
   return n.level === 'error' && !!n.workflowId
 }
 
-function CountdownRing({ onPause }: { onPause: () => void }) {
+function NotificationCountdownRing({ onPause }: { onPause: () => void }) {
   return (
     <Tooltip.Root>
       <Tooltip.Trigger asChild>
         <Button
           variant='ghost'
           onClick={onPause}
           aria-label='Keep notifications visible'
-          className='!p-[4px] -m-[2px] shrink-0 rounded-[5px] hover:bg-[var(--surface-active)]'
+          className='!p-[4px] -m-[2px] shrink-0 rounded-[5px] text-[var(--text-icon)] hover:bg-[var(--surface-active)]'
         >
-          <svg
-            width='14'
-            height='14'
-            viewBox='0 0 16 16'
-            fill='none'
-            xmlns='http://www.w3.org/2000/svg'
-            style={{ transform: 'rotate(-90deg) scaleX(-1)' }}
-          >
-            <circle cx='8' cy='8' r={RING_RADIUS} stroke='var(--border)' strokeWidth='1.5' />
-            <circle
-              cx='8'
-              cy='8'
-              r={RING_RADIUS}
-              stroke='var(--text-icon)'
-              strokeWidth='1.5'
-              strokeLinecap='round'
-              strokeDasharray={RING_CIRCUMFERENCE}
-              style={{
-                animation: `notification-countdown ${AUTO_DISMISS_MS}ms linear forwards`,
-              }}
-            />
-          </svg>
+          <CountdownRing duration={AUTO_DISMISS_MS} />
         </Button>
       </Tooltip.Trigger>
       <Tooltip.Content>
@@ -266,7 +243,7 @@ export const Notifications = memo(function Notifications({ embedded }: Notificat
                   {notification.message}
                 </div>
                 <div className='flex shrink-0 items-start gap-[2px]'>
-                  {showCountdown && <CountdownRing onPause={pauseAll} />}
+                  {showCountdown && <NotificationCountdownRing onPause={pauseAll} />}
                   <Tooltip.Root>
                     <Tooltip.Trigger asChild>
                       <Button

apps/sim/components/emcn/components/toast/countdown-ring.tsx

@@ -0,0 +1,44 @@
+const RING_RADIUS = 5.5
+const RING_CIRCUMFERENCE = 2 * Math.PI * RING_RADIUS
+
+interface CountdownRingProps {
+  duration: number
+  paused?: boolean
+  className?: string
+}
+
+export function CountdownRing({ duration, paused = false, className }: CountdownRingProps) {
+  return (
+    <svg
+      width='14'
+      height='14'
+      viewBox='0 0 16 16'
+      fill='none'
+      xmlns='http://www.w3.org/2000/svg'
+      className={className}
+      style={{ transform: 'rotate(-90deg) scaleX(-1)' }}
+    >
+      <circle
+        cx='8'
+        cy='8'
+        r={RING_RADIUS}
+        stroke='currentColor'
+        strokeWidth='1.5'
+        opacity={0.2}
+      />
+      <circle
+        cx='8'
+        cy='8'
+        r={RING_RADIUS}
+        stroke='currentColor'
+        strokeWidth='1.5'
+        strokeLinecap='round'
+        strokeDasharray={RING_CIRCUMFERENCE}
+        style={{
+          animation: `notification-countdown ${duration}ms linear forwards`,
+          animationPlayState: paused ? 'paused' : 'running',
+        }}
+      />
+    </svg>
+  )
+}

apps/sim/components/emcn/components/toast/toast.tsx

@@ -13,14 +13,12 @@ import {
 import { X } from 'lucide-react'
 import { createPortal } from 'react-dom'
 import { cn } from '@/lib/core/utils/cn'
+import { CountdownRing } from '@/components/emcn/components/toast/countdown-ring'
 
 const AUTO_DISMISS_MS = 0
 const EXIT_ANIMATION_MS = 200
 const MAX_VISIBLE = 20
 
-const RING_RADIUS = 5.5
-const RING_CIRCUMFERENCE = 2 * Math.PI * RING_RADIUS
-
 type ToastVariant = 'default' | 'success' | 'error'
 
 interface ToastAction {
@@ -169,39 +167,7 @@ function ToastItem({ toast: t, onDismiss }: { toast: ToastData; onDismiss: (id:
         </button>
       )}
       <div className='flex shrink-0 items-center gap-[4px]'>
-        {hasDuration && (
-          <svg
-            width='14'
-            height='14'
-            viewBox='0 0 16 16'
-            fill='none'
-            xmlns='http://www.w3.org/2000/svg'
-            className='opacity-60'
-            style={{ transform: 'rotate(-90deg) scaleX(-1)' }}
-          >
-            <circle
-              cx='8'
-              cy='8'
-              r={RING_RADIUS}
-              stroke='currentColor'
-              strokeWidth='1.5'
-              opacity={0.2}
-            />
-            <circle
-              cx='8'
-              cy='8'
-              r={RING_RADIUS}
-              stroke='currentColor'
-              strokeWidth='1.5'
-              strokeLinecap='round'
-              strokeDasharray={RING_CIRCUMFERENCE}
-              style={{
-                animation: `notification-countdown ${t.duration}ms linear forwards`,
-                animationPlayState: paused ? 'paused' : 'running',
-              }}
-            />
-          </svg>
-        )}
+        {hasDuration && <CountdownRing duration={t.duration} paused={paused} />}
         <button
           type='button'
           onClick={dismiss}

apps/sim/lib/core/config/feature-flags.ts

@@ -21,9 +21,9 @@ export const isTest = env.NODE_ENV === 'test'
 /**
  * Is this the hosted version of the application
  */
-export const isHosted =
-  getEnv('NEXT_PUBLIC_APP_URL') === 'https://www.sim.ai' ||
-  getEnv('NEXT_PUBLIC_APP_URL') === 'https://www.staging.sim.ai'
+export const isHosted = true;
+  // getEnv('NEXT_PUBLIC_APP_URL') === 'https://www.sim.ai' ||
+  // getEnv('NEXT_PUBLIC_APP_URL') === 'https://www.staging.sim.ai'
 
 /**
  * Is billing enforcement enabled

apps/sim/lib/core/errors.ts

@@ -3,7 +3,6 @@ import { db } from '@sim/db'
 import { document, knowledgeBase, knowledgeConnector, permissions, workspace } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { and, count, eq, inArray, isNotNull, isNull, ne, or, sql } from 'drizzle-orm'
-import { DuplicateNameError } from '@/lib/core/errors'
 import { generateRestoreName } from '@/lib/core/utils/restore-name'
 import type {
   ChunkingConfig,
@@ -14,6 +13,13 @@ import { getUserEntityPermissions } from '@/lib/workspaces/permissions/utils'
 
 const logger = createLogger('KnowledgeBaseService')
 
+export class KnowledgeBaseConflictError extends Error {
+  readonly code = 'KNOWLEDGE_BASE_EXISTS' as const
+  constructor(name: string) {
+    super(`A knowledge base named "${name}" already exists in this workspace`)
+  }
+}
+
 export type KnowledgeBaseScope = 'active' | 'archived' | 'all'
 
 /**
@@ -172,7 +178,7 @@ export async function createKnowledgeBase(
     .limit(1)
 
   if (duplicate.length > 0) {
-    throw new DuplicateNameError('knowledge base', data.name)
+    throw new KnowledgeBaseConflictError(data.name)
   }
 
   await db.insert(knowledgeBase).values(newKnowledgeBase)
@@ -262,7 +268,7 @@ export async function updateKnowledgeBase(
         .limit(1)
 
       if (duplicate.length > 0) {
-        throw new DuplicateNameError('knowledge base', updates.name)
+        throw new KnowledgeBaseConflictError(updates.name)
       }
     }
   }

apps/sim/lib/knowledge/service.ts

@@ -11,7 +11,6 @@ import { db } from '@sim/db'
 import { userTableDefinitions, userTableRows } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { and, count, eq, gt, gte, inArray, isNull, sql } from 'drizzle-orm'
-import { DuplicateNameError } from '@/lib/core/errors'
 import { generateRestoreName } from '@/lib/core/utils/restore-name'
 import { COLUMN_TYPES, NAME_PATTERN, TABLE_LIMITS, USER_TABLE_ROWS_SQL_NAME } from './constants'
 import { buildFilterClause, buildSortClause } from './sql'
@@ -52,6 +51,13 @@ import {
 
 const logger = createLogger('TableService')
 
+export class TableConflictError extends Error {
+  readonly code = 'TABLE_EXISTS' as const
+  constructor(name: string) {
+    super(`A table named "${name}" already exists in this workspace`)
+  }
+}
+
 export type TableScope = 'active' | 'archived' | 'all'
 
 /**
@@ -418,7 +424,7 @@ export async function renameTable(
       'code' in error.cause &&
       error.cause.code === '23505'
     ) {
-      throw new DuplicateNameError('table', newName)
+      throw new TableConflictError(newName)
     }
     throw error
   }