Skip to content

detect difference between architectures when determining if driver is already found #33

@bandophahita

Description

@bandophahita

This is likely only really an issue on the new apple silicon macs but it could pertain to folks running docker and downloading the webdriver to a shared volume between the host machine and the container (I'm guessing it's a pretty rare edge case)

When pyderman checks to see if the file_path already exists it doesn't do a check between the file architectures. While it is possible for chromedriver compiled for amd64 to run on an m1/m2 mac, the arm64 version really ought to be used.

In theory, we should determine if the existing file is in the "proper" architecture when deciding to overwrite the file or not.

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions