Dockerize beast update#458
Open
kunrex wants to merge 4 commits into
Open
Conversation
sukhman-sukh
reviewed
Apr 2, 2026
| RUN apt-get update && apt-get install -y ca-certificates \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN apt-get update && \ |
sukhman-sukh
reviewed
Apr 2, 2026
| RUN cp scripts/docker-enter /usr/bin/docker-enter && \ | ||
| cp scripts/docker_enter /usr/bin/docker_enter && \ | ||
| chmod u+s /usr/bin/docker_enter && \ | ||
| gcc -o /usr/bin/importenv scripts/importenv.c |
Collaborator
There was a problem hiding this comment.
Also, check one more thing here. I think these binaries are created here in builder but not passed to next stage. If this is the case, either fix that or remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the docker client to the image, since redis checks and docker compose both depend on
execand beast, at the moment, does not use docker api packages that supports compose.Long Term Fix: migrate the docker API to use the newer API packages.