Skip to content

Use Eigen::Ref<> ? #73

@olilarkin

Description

@olilarkin

I haven't properly checked if this is the case here, but using Eigen types as function parameters can result in unwanted temporary copies in some cases. The Eigen::Ref<> class exists to work around this. Further information here: http://eigen.tuxfamily.org/dox/TopicFunctionTakingEigenTypes.html#TopicUsingRefClass

I wondered if this might be one lever for optimizing the NAMCore code

https://github.com/sdatkinson/NeuralAmpModelerCore/blob/885a535d29022138f3efcbfd73aed4743f750b68/NAM/wavenet.h#L102C6-L102C6

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions