Commit 79b99fa
Address adversarial review findings for per-channel norm
1. Improve error message when norm list + cmap resolution fails —
now mentions cmap/channel mismatch as possible cause instead of
the misleading "multiple colormaps are used"
2. Unwrap length-1 cmap_params lists to scalar so single-channel
images still take the fast path (proper norm in imshow + colorbar)
3. Make Normalize copy unconditional in the multi-channel compositing
loop — eliminates fragile conditional that only copied auto-ranging
norms, preventing any future cross-channel mutation bugs
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 9ba4c48 commit 79b99fa
3 files changed
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
658 | 658 | | |
659 | 659 | | |
660 | 660 | | |
661 | | - | |
662 | | - | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
663 | 664 | | |
664 | 665 | | |
665 | 666 | | |
666 | 667 | | |
667 | 668 | | |
668 | 669 | | |
669 | 670 | | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
670 | 675 | | |
671 | 676 | | |
672 | 677 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1313 | 1313 | | |
1314 | 1314 | | |
1315 | 1315 | | |
1316 | | - | |
1317 | | - | |
| 1316 | + | |
| 1317 | + | |
1318 | 1318 | | |
1319 | 1319 | | |
1320 | 1320 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
478 | 478 | | |
479 | 479 | | |
480 | 480 | | |
481 | | - | |
| 481 | + | |
482 | 482 | | |
0 commit comments