PR #828 shows quite well which structs are needed for a self defined ExtrinsicParams feature. In the extrinsic_params file however, this is not visible as Traits and implementations are quite mixed.
Suggestion: Split the file into:
- Traits
- Helper Implementation that are needed (maybe that makes sense to keep together with the Traits)
- Specific Node implementation. In our case it's
Generic, but it's actually still just compatible with the "newest" node, though the types are generic and not hardcoded.
PR #828 shows quite well which structs are needed for a self defined ExtrinsicParams feature. In the
extrinsic_paramsfile however, this is not visible as Traits and implementations are quite mixed.Suggestion: Split the file into:
Generic, but it's actually still just compatible with the "newest" node, though the types are generic and not hardcoded.