LLVMCodeBuilder: Implement subtract operator

Author: adazem009

src/dev/engine/internal/icodebuilder.h

@@ -25,6 +25,7 @@ class ICodeBuilder
         virtual void addListContents(List *list) = 0;
 
         virtual void createAdd() = 0;
+        virtual void createSub() = 0;
         virtual void beginIfStatement() = 0;
         virtual void beginElseBranch() = 0;
         virtual void endIf() = 0;

src/dev/engine/internal/llvmcodebuilder.cpp

@@ -98,6 +98,16 @@ std::shared_ptr<ExecutableCode> LLVMCodeBuilder::finalize()
                 break;
             }
 
+            case Step::Type::Sub: {
+                assert(step.args.size() == 2);
+                const auto &arg1 = step.args[0];
+                const auto &arg2 = step.args[1];
+                llvm::Value *num1 = removeNaN(castValue(arg1.second, arg1.first));
+                llvm::Value *num2 = removeNaN(castValue(arg2.second, arg2.first));
+                step.functionReturnReg->value = m_builder.CreateFSub(num1, num2);
+                break;
+            }
+
             case Step::Type::Yield:
                 if (!m_warp) {
                     freeHeap();
@@ -427,6 +437,11 @@ void LLVMCodeBuilder::createAdd()
     createOp(Step::Type::Add, 2);
 }
 
+void LLVMCodeBuilder::createSub()
+{
+    createOp(Step::Type::Sub, 2);
+}
+
 void LLVMCodeBuilder::beginIfStatement()
 {
     Step step(Step::Type::BeginIf);

src/dev/engine/internal/llvmcodebuilder.h

@@ -27,6 +27,7 @@ class LLVMCodeBuilder : public ICodeBuilder
         void addListContents(List *list) override;
 
         void createAdd() override;
+        void createSub() override;
         void beginIfStatement() override;
         void beginElseBranch() override;
         void endIf() override;
@@ -60,6 +61,7 @@ class LLVMCodeBuilder : public ICodeBuilder
                 {
                     FunctionCall,
                     Add,
+                    Sub,
                     Yield,
                     BeginIf,
                     BeginElse,

test/dev/llvm/llvmcodebuilder_test.cpp

@@ -245,6 +245,51 @@ TEST_F(LLVMCodeBuilderTest, Add)
     ASSERT_EQ(testing::internal::GetCapturedStdout(), expected);
 }
 
+TEST_F(LLVMCodeBuilderTest, Subtract)
+{
+    std::string expected;
+
+    auto addOpTest = [this, &expected](Value v1, Value v2, double expectedResult) {
+        m_builder->addConstValue(v1);
+        m_builder->addConstValue(v2);
+        m_builder->createSub();
+        m_builder->addFunctionCall("test_print_string", Compiler::StaticType::Void, { Compiler::StaticType::String });
+
+        m_builder->addConstValue(v1);
+        m_builder->addFunctionCall("test_const_number", Compiler::StaticType::Number, { Compiler::StaticType::Number });
+        m_builder->addConstValue(v2);
+        m_builder->addFunctionCall("test_const_number", Compiler::StaticType::Number, { Compiler::StaticType::Number });
+        m_builder->createSub();
+        m_builder->addFunctionCall("test_print_string", Compiler::StaticType::Void, { Compiler::StaticType::String });
+
+        std::string str = Value(expectedResult).toString() + '\n';
+        expected += str;
+        expected += str;
+    };
+
+    createBuilder(true);
+
+    addOpTest(50, 25, 25);
+    addOpTest(-500, 25, -525);
+    addOpTest(-500, -25, -475);
+    addOpTest("2.54", "6.28", -3.74);
+    addOpTest(2.54, "-6.28", 8.82);
+    addOpTest(true, true, 0);
+    addOpTest("Infinity", "Infinity", std::numeric_limits<double>::quiet_NaN());
+    addOpTest("Infinity", "-Infinity", std::numeric_limits<double>::infinity());
+    addOpTest("-Infinity", "Infinity", -std::numeric_limits<double>::infinity());
+    addOpTest("-Infinity", "-Infinity", std::numeric_limits<double>::quiet_NaN());
+    addOpTest(1, "NaN", 1);
+    addOpTest("NaN", 1, -1);
+
+    auto code = m_builder->finalize();
+    auto ctx = code->createExecutionContext(&m_target);
+
+    testing::internal::CaptureStdout();
+    code->run(ctx.get());
+    ASSERT_EQ(testing::internal::GetCapturedStdout(), expected);
+}
+
 TEST_F(LLVMCodeBuilderTest, Yield)
 {
     auto build = [this]() {

test/mocks/codebuildermock.h

@@ -15,6 +15,7 @@ class CodeBuilderMock : public ICodeBuilder
         MOCK_METHOD(void, addListContents, (List *), (override));
 
         MOCK_METHOD(void, createAdd, (), (override));
+        MOCK_METHOD(void, createSub, (), (override));
         MOCK_METHOD(void, beginIfStatement, (), (override));
         MOCK_METHOD(void, beginElseBranch, (), (override));
         MOCK_METHOD(void, endIf, (), (override));