Variable: Refactor

Author: adazem009

src/scratch/variable.cpp

@@ -5,7 +5,7 @@
 using namespace libscratchcpp;
 
 /*! Constructs Variable. */
-Variable::Variable(std::string id, std::string name, Value value, bool isCloudVariable) :
+Variable::Variable(const std::string &id, const std::string &name, const Value &value, bool isCloudVariable) :
     m_name(name),
     m_value(value),
     m_isCloudVariable(isCloudVariable)
@@ -14,29 +14,17 @@ Variable::Variable(std::string id, std::string name, Value value, bool isCloudVa
 }
 
 /*! Constructs an empty Variable. */
-Variable::Variable(std::string id, std::string name, bool isCloudVariable) :
+Variable::Variable(const std::string &id, const std::string &name, bool isCloudVariable) :
     Variable(id, name, Value(), isCloudVariable)
 {
 }
 
 /*! Returns the name of the variable. */
-std::string Variable::name() const
+const std::string &Variable::name() const
 {
     return m_name;
 }
 
-/*! Returns the value. */
-const Value &Variable::value() const
-{
-    return m_value;
-}
-
-/*! Sets the value. */
-void Variable::setValue(const Value &value)
-{
-    m_value = value;
-}
-
 /*! Returns true if the variable is a cloud variable. */
 bool Variable::isCloudVariable() const
 {

src/scratch/variable.h

@@ -13,14 +13,17 @@ namespace libscratchcpp
 class LIBSCRATCHCPP_EXPORT Variable : public IEntity
 {
     public:
-        Variable(std::string id, std::string name, Value value = Value(), bool isCloudVariable = false);
-        Variable(std::string id, std::string name, bool isCloudVariable);
+        Variable(const std::string &id, const std::string &name, const Value &value = Value(), bool isCloudVariable = false);
+        Variable(const std::string &id, const std::string &name, bool isCloudVariable);
         Variable(const Variable &) = delete;
 
-        std::string name() const;
+        const std::string &name() const;
 
-        const Value &value() const;
-        void setValue(const Value &value);
+        /*! Returns the value. */
+        inline const Value &value() const { return m_value; }
+
+        /*! Sets the value. */
+        inline void setValue(const Value &value) { m_value = value; }
 
         bool isCloudVariable() const;
         void setIsCloudVariable(bool isCloudVariable);