Skip to content

Commit 447cf93

Browse files
committed
Use a better value for the default groupId
This project migrated from ImageJ2, where net.imagej was an intuitive choice for default groupId. But the project is part of the Scijava scripting framework now, so a groupId matching that fact makes more sense. We use org.scijava.scripting.java, rather than only org.scijava, to avoid potential name clashes with actual SciJava projects such as scijava-common, scripting-java, etc.
1 parent 1c965a1 commit 447cf93

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/main/java/org/scijava/plugins/scripting/java/JavaEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@
9393
*/
9494
public class JavaEngine extends AbstractScriptEngine {
9595

96-
private final static String DEFAULT_GROUP_ID = "net.imagej";
96+
private final static String DEFAULT_GROUP_ID = "org.scijava.scripting.java";
9797
private final static String DEFAULT_VERSION = "1.0.0-SNAPSHOT";
9898

9999
/**

src/test/java/org/scijava/plugins/scripting/java/JavaEngineTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ private File makeProject(final String mainClass, final String... args)
198198
" xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0\n" + //
199199
" http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n" + //
200200
" <modelVersion>4.0.0</modelVersion>\n" + //
201-
" <groupId>net.imagej</groupId>\n" + //
201+
" <groupId>org.scijava.scripting.java</groupId>\n" + //
202202
" <artifactId>MinimalTest</artifactId>\n" + //
203203
" <version>1.0.0</version>\n" + //
204204
" <build>\n" + //

src/test/java/org/scijava/plugins/scripting/java/MakeJarTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ public void testSingle() throws Exception {
5858
final File output = new File(tmpDir, "test.jar");
5959
engine.makeJar(file, false, output, writer);
6060
assertJarEntries(output, "META-INF/MANIFEST.MF",
61-
"META-INF/maven/net.imagej/Dummy/pom.xml", "Dummy.class");
61+
"META-INF/maven/org.scijava.scripting.java/Dummy/pom.xml", "Dummy.class");
6262
engine.makeJar(file, true, output, writer);
6363
assertJarEntries(output, "META-INF/MANIFEST.MF",
64-
"META-INF/maven/net.imagej/Dummy/pom.xml", "Dummy.class",
64+
"META-INF/maven/org.scijava.scripting.java/Dummy/pom.xml", "Dummy.class",
6565
"pom.xml", "src/main/java/Dummy.java");
6666
}
6767

0 commit comments

Comments
 (0)