Skip to content

Commit e2ce266

Browse files
committed
ModuleSearcher: remove validity restriction
In contrast to the visible and enabled checks, verifying that a command is valid triggers class loading and parameter parsing. It also hopefully avoids problems like this: http://forum.imagej.net/t/a-search-bar-for-imagej/6735/12
1 parent c6cc20d commit e2ce266

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/main/java/org/scijava/search/module/ModuleSearcher.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,7 @@ public static String location(final ModuleInfo info, final String baseDir) {
152152
// -- Helper methods --
153153

154154
private boolean isGoodModule(final ModuleInfo info) {
155-
return info.isValid() && info.isVisible() && info.isEnabled() &&
156-
title(info) != null;
155+
return info.isVisible() && info.isEnabled() && title(info) != null;
157156
}
158157

159158
private boolean startsWith(final ModuleInfo info, final String desiredLower) {

0 commit comments

Comments
 (0)