LastRecentlyUsed: fix bug in replace function

ctrueden · ctrueden · commit fae4829ccdf9 · 2023-02-22T14:00:34.000-06:00
Closes #453.
diff --git a/src/main/java/org/scijava/util/LastRecentlyUsed.java b/src/main/java/org/scijava/util/LastRecentlyUsed.java
@@ -143,7 +143,7 @@ public boolean replace(final int index, T newValue) {
 			throw new IllegalArgumentException("No current entry at position " +
 				index);
 		}
-		if (newValue.equals(previous)) return false;
+		if (newValue.equals(previousValue)) return false;
 		map.remove(previousValue);
 		map.put(newValue, index);
 		entries[index] = newValue;

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ public boolean replace(final int index, T newValue) {`
`143`	`143`	`throw new IllegalArgumentException("No current entry at position " +`
`144`	`144`	`index);`
`145`	`145`	`}`
`146`		`- if (newValue.equals(previous)) return false;`
	`146`	`+ if (newValue.equals(previousValue)) return false;`
`147`	`147`	`map.remove(previousValue);`
`148`	`148`	`map.put(newValue, index);`
`149`	`149`	`entries[index] = newValue;`