Skip to content

Commit e125366

Browse files
awalter17ctrueden
authored andcommitted
Modify tests to no longer depend on obsolete files
This also narrows the return types as appropriate for each concrete type.
1 parent ab408b6 commit e125366

23 files changed

+635
-356
lines changed

src/test/java/org/scijava/convert/BigIntegerToBigDecimalConverterTest.java

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131

3232
package org.scijava.convert;
3333

34+
import java.math.BigDecimal;
3435
import java.math.BigInteger;
3536

3637
import org.scijava.convert.NumberConverters.BigIntegerToBigDecimalConverter;
@@ -40,11 +41,12 @@
4041
*
4142
* @author Alison Walter
4243
*/
43-
public class BigIntegerToBigDecimalConverterTest extends NumberToBigDecimalTest
44+
public class BigIntegerToBigDecimalConverterTest extends
45+
AbstractNumberConverterTests
4446
{
4547

4648
@Override
47-
public Number getSrc() {
49+
public BigInteger getSrc() {
4850
return BigInteger.valueOf(7l);
4951
}
5052

@@ -54,7 +56,17 @@ public Number getSrc() {
5456
}
5557

5658
@Override
57-
public Number getInvalidInput() {
58-
return new Long(46l);
59+
public BigDecimal getExpectedValue() {
60+
return new BigDecimal(7d);
61+
}
62+
63+
@Override
64+
public Long getInvalidInput() {
65+
return 46l;
66+
}
67+
68+
@Override
69+
public Class<?> getInvalidOutput() {
70+
return Float.class;
5971
}
6072
}

src/test/java/org/scijava/convert/ByteToBigDecimalConverterTest.java

Lines changed: 30 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,27 +31,41 @@
3131

3232
package org.scijava.convert;
3333

34+
import java.math.BigDecimal;
35+
3436
import org.scijava.convert.NumberConverters.ByteToBigDecimalConverter;
3537

3638
/**
3739
* Tests {@link ByteToBigDecimalConverter}.
3840
*
3941
* @author Alison Walter
4042
*/
41-
public class ByteToBigDecimalConverterTest extends NumberToBigDecimalTest {
42-
43-
@Override
44-
public Number getSrc() {
45-
return new Byte((byte) 7);
46-
}
47-
48-
@Override
49-
public NumberToNumberConverter<?, ?> getConverter() {
50-
return new NumberConverters.ByteToBigDecimalConverter();
51-
}
52-
53-
@Override
54-
public Number getInvalidInput() {
55-
return new Short((short) 101);
56-
}
43+
public class ByteToBigDecimalConverterTest extends AbstractNumberConverterTests
44+
{
45+
46+
@Override
47+
public Byte getSrc() {
48+
return (byte) 7;
49+
}
50+
51+
@Override
52+
public NumberToNumberConverter<?, ?> getConverter() {
53+
return new NumberConverters.ByteToBigDecimalConverter();
54+
}
55+
56+
@Override
57+
public BigDecimal getExpectedValue() {
58+
return new BigDecimal(7d);
59+
}
60+
61+
@Override
62+
public Short getInvalidInput() {
63+
return (short) 101;
64+
}
65+
66+
@Override
67+
public Class<?> getInvalidOutput() {
68+
return Float.class;
69+
}
70+
5771
}

src/test/java/org/scijava/convert/ByteToBigIntegerConverterTest.java

Lines changed: 29 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,28 +31,41 @@
3131

3232
package org.scijava.convert;
3333

34+
import java.math.BigInteger;
35+
3436
import org.scijava.convert.NumberConverters.ByteToBigIntegerConverter;
3537

3638
/**
3739
* Tests {@link ByteToBigIntegerConverter}.
3840
*
3941
* @author Alison Walter
4042
*/
41-
public class ByteToBigIntegerConverterTest extends NumberToBigIntegerTest {
42-
43-
@Override
44-
public Number getSrc() {
45-
return new Byte((byte) 7);
46-
}
47-
48-
@Override
49-
public NumberToNumberConverter<?, ?> getConverter() {
50-
return new NumberConverters.ByteToBigIntegerConverter();
51-
}
52-
53-
@Override
54-
public Number getInvalidInput() {
55-
return new Short((short) 101);
56-
}
43+
public class ByteToBigIntegerConverterTest extends AbstractNumberConverterTests
44+
{
45+
46+
@Override
47+
public Byte getSrc() {
48+
return (byte) 7;
49+
}
50+
51+
@Override
52+
public NumberToNumberConverter<?, ?> getConverter() {
53+
return new NumberConverters.ByteToBigIntegerConverter();
54+
}
55+
56+
@Override
57+
public BigInteger getExpectedValue() {
58+
return BigInteger.valueOf(7l);
59+
}
60+
61+
@Override
62+
public Short getInvalidInput() {
63+
return (short) 101;
64+
}
65+
66+
@Override
67+
public Class<?> getInvalidOutput() {
68+
return Byte.class;
5769
}
5870

71+
}

src/test/java/org/scijava/convert/ByteToDoubleConverterTest.java

Lines changed: 27 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -38,20 +38,31 @@
3838
*
3939
* @author Alison Walter
4040
*/
41-
public class ByteToDoubleConverterTest extends NumberToDoubleTest {
42-
43-
@Override
44-
public Number getSrc() {
45-
return new Byte((byte) 7);
46-
}
47-
48-
@Override
49-
public NumberToNumberConverter<?, ?> getConverter() {
50-
return new NumberConverters.ByteToDoubleConverter();
51-
}
52-
53-
@Override
54-
public Number getInvalidInput() {
55-
return new Short((short) 101);
56-
}
41+
public class ByteToDoubleConverterTest extends AbstractNumberConverterTests {
42+
43+
@Override
44+
public Byte getSrc() {
45+
return (byte) 7;
46+
}
47+
48+
@Override
49+
public NumberToNumberConverter<?, ?> getConverter() {
50+
return new NumberConverters.ByteToDoubleConverter();
51+
}
52+
53+
@Override
54+
public Double getExpectedValue() {
55+
return 7.0d;
56+
}
57+
58+
@Override
59+
public Short getInvalidInput() {
60+
return (short) 101;
61+
}
62+
63+
@Override
64+
public Class<?> getInvalidOutput() {
65+
return Byte.class;
66+
}
67+
5768
}

src/test/java/org/scijava/convert/ByteToFloatConverterTest.java

Lines changed: 26 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -38,20 +38,30 @@
3838
*
3939
* @author Alison Walter
4040
*/
41-
public class ByteToFloatConverterTest extends NumberToFloatTest {
42-
43-
@Override
44-
public Number getSrc() {
45-
return new Byte((byte) 7);
46-
}
47-
48-
@Override
49-
public NumberToNumberConverter<?, ?> getConverter() {
50-
return new NumberConverters.ByteToFloatConverter();
51-
}
52-
53-
@Override
54-
public Number getInvalidInput() {
55-
return new Double(7.67d);
56-
}
41+
public class ByteToFloatConverterTest extends AbstractNumberConverterTests {
42+
43+
@Override
44+
public Byte getSrc() {
45+
return (byte) 7;
46+
}
47+
48+
@Override
49+
public NumberToNumberConverter<?, ?> getConverter() {
50+
return new NumberConverters.ByteToFloatConverter();
51+
}
52+
53+
@Override
54+
public Float getExpectedValue() {
55+
return 7f;
56+
}
57+
58+
@Override
59+
public Double getInvalidInput() {
60+
return 7.67d;
61+
}
62+
63+
@Override
64+
public Class<?> getInvalidOutput() {
65+
return Long.class;
66+
}
5767
}

src/test/java/org/scijava/convert/ByteToIntegerConverterTest.java

Lines changed: 27 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -38,20 +38,31 @@
3838
*
3939
* @author Alison Walter
4040
*/
41-
public class ByteToIntegerConverterTest extends NumberToIntegerTest {
42-
43-
@Override
44-
public Number getSrc() {
45-
return new Byte((byte) 7);
46-
}
47-
48-
@Override
49-
public NumberToNumberConverter<?, ?> getConverter() {
50-
return new NumberConverters.ByteToIntegerConverter();
51-
}
52-
53-
@Override
54-
public Number getInvalidInput() {
55-
return new Long(12l);
56-
}
41+
public class ByteToIntegerConverterTest extends AbstractNumberConverterTests {
42+
43+
@Override
44+
public Byte getSrc() {
45+
return (byte) 7;
46+
}
47+
48+
@Override
49+
public NumberToNumberConverter<?, ?> getConverter() {
50+
return new NumberConverters.ByteToIntegerConverter();
51+
}
52+
53+
@Override
54+
public Integer getExpectedValue() {
55+
return 7;
56+
}
57+
58+
@Override
59+
public Long getInvalidInput() {
60+
return 12l;
61+
}
62+
63+
@Override
64+
public Class<?> getInvalidOutput() {
65+
return Short.class;
66+
}
67+
5768
}

src/test/java/org/scijava/convert/ByteToLongConverterTest.java

Lines changed: 27 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -38,20 +38,31 @@
3838
*
3939
* @author Alison Walter
4040
*/
41-
public class ByteToLongConverterTest extends NumberToLongTest {
42-
43-
@Override
44-
public Number getSrc() {
45-
return new Byte((byte) 7);
46-
}
47-
48-
@Override
49-
public NumberToNumberConverter<?, ?> getConverter() {
50-
return new NumberConverters.ByteToLongConverter();
51-
}
52-
53-
@Override
54-
public Number getInvalidInput() {
55-
return new Double(12d);
56-
}
41+
public class ByteToLongConverterTest extends AbstractNumberConverterTests {
42+
43+
@Override
44+
public Byte getSrc() {
45+
return (byte) 7;
46+
}
47+
48+
@Override
49+
public NumberToNumberConverter<?, ?> getConverter() {
50+
return new NumberConverters.ByteToLongConverter();
51+
}
52+
53+
@Override
54+
public Long getExpectedValue() {
55+
return 7l;
56+
}
57+
58+
@Override
59+
public Double getInvalidInput() {
60+
return 12d;
61+
}
62+
63+
@Override
64+
public Class<?> getInvalidOutput() {
65+
return Float.class;
66+
}
67+
5768
}

src/test/java/org/scijava/convert/ByteToShortConverterTest.java

Lines changed: 26 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -38,21 +38,31 @@
3838
*
3939
* @author Alison Walter
4040
*/
41-
public class ByteToShortConverterTest extends NumberToShortTest {
42-
43-
@Override
44-
public Number getSrc() {
45-
return new Byte((byte) 7);
46-
}
47-
48-
@Override
49-
public NumberToNumberConverter<?, ?> getConverter() {
50-
return new NumberConverters.ByteToShortConverter();
51-
}
52-
53-
@Override
54-
public Number getInvalidInput() {
55-
return new Integer(12);
56-
}
41+
public class ByteToShortConverterTest extends AbstractNumberConverterTests {
42+
43+
@Override
44+
public Byte getSrc() {
45+
return (byte) 7;
46+
}
47+
48+
@Override
49+
public NumberToNumberConverter<?, ?> getConverter() {
50+
return new NumberConverters.ByteToShortConverter();
51+
}
52+
53+
@Override
54+
public Short getExpectedValue() {
55+
return (short) 7;
56+
}
57+
58+
@Override
59+
public Integer getInvalidInput() {
60+
return 12;
61+
}
62+
63+
@Override
64+
public Class<?> getInvalidOutput() {
65+
return Float.class;
66+
}
5767

5868
}

0 commit comments

Comments
 (0)