ContextCreationTest: remove unneeded method

Now that we have the handy ArrayUtils.array method,
we can ditch the less general services helper method.

Author: ctrueden

src/test/java/org/scijava/ContextCreationTest.java

@@ -38,6 +38,7 @@
 import static org.junit.Assert.assertSame;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
+import static org.scijava.util.ArrayUtils.array;
 
 import java.util.Arrays;
 import java.util.List;
@@ -285,50 +286,48 @@ public void testNonStrictOptionalMissingTransitive() {
 	 * Verifies that the order plugins appear in the PluginIndex and Service list
 	 * does not affect which services are loaded.
 	 */
-	@SuppressWarnings("unchecked")
 	@Test
 	public void testClassOrder() {
 		final int expectedSize = 2;
 
 		// Same order, Base first
-		Context c =
-			createContext(pluginIndex(BaseImpl.class, ExtensionImpl.class), services(
-				BaseService.class, ExtensionService.class));
+		Context c = createContext(//
+			pluginIndex(BaseImpl.class, ExtensionImpl.class), //
+			array(BaseService.class, ExtensionService.class));
 		assertEquals(expectedSize, c.getServiceIndex().size());
 
 		// Same order, Extension first
-		c =
-			createContext(pluginIndex(ExtensionImpl.class, BaseImpl.class), services(
-				ExtensionService.class, BaseService.class));
+		c = createContext(//
+			pluginIndex(ExtensionImpl.class, BaseImpl.class), //
+			array(ExtensionService.class, BaseService.class));
 		assertEquals(expectedSize, c.getServiceIndex().size());
 
 		// Different order, Extension first
-		c =
-			createContext(pluginIndex(ExtensionImpl.class, BaseImpl.class), services(
-				BaseService.class, ExtensionService.class));
+		c = createContext(//
+			pluginIndex(ExtensionImpl.class, BaseImpl.class), //
+			array(BaseService.class, ExtensionService.class));
 		assertEquals(expectedSize, c.getServiceIndex().size());
 
 		// Different order, Base first
-		c =
-			createContext(pluginIndex(BaseImpl.class, ExtensionImpl.class), services(
-				ExtensionService.class, BaseService.class));
+		c = createContext(//
+			pluginIndex(BaseImpl.class, ExtensionImpl.class), //
+			array(ExtensionService.class, BaseService.class));
 		assertEquals(expectedSize, c.getServiceIndex().size());
 	}
 
 	/**
 	 * Verifies that the Service index created when using Abstract classes is the
 	 * same as for interfaces.
 	 */
-	@SuppressWarnings("unchecked")
 	@Test
 	public void testAbstractClasslist() {
-		final Context cAbstract =
-			createContext(pluginIndex(BaseImpl.class, ExtensionImpl.class), services(
-				AbstractBase.class, AbstractExtension.class));
+		final Context cAbstract = createContext(//
+			pluginIndex(BaseImpl.class, ExtensionImpl.class), //
+			array(AbstractBase.class, AbstractExtension.class));
 
-		final Context cService =
-			createContext(pluginIndex(BaseImpl.class, ExtensionImpl.class), services(
-				BaseService.class, ExtensionService.class));
+		final Context cService = createContext(//
+			pluginIndex(BaseImpl.class, ExtensionImpl.class), //
+			array(BaseService.class, ExtensionService.class));
 
 		assertEquals(cService.getServiceIndex().size(), cAbstract.getServiceIndex()
 			.size());
@@ -423,16 +422,6 @@ private Context createContext(final PluginIndex index,
 			index);
 	}
 
-	/**
-	 * Convenience method since you can't instantiate a Class<? extends Service>
-	 * array.
-	 */
-	private Class<? extends Service>[] services(
-		final Class<? extends Service>... serviceClasses)
-	{
-		return serviceClasses;
-	}
-
 	/**
 	 * Creates a PluginIndex and adds all the provided classes as plugins, indexed
 	 * under Service.class