Skip to content

Commit a9a109c

Browse files
committed
PrefService: remove setStaticBehavior method
This was an unnecessary method. Originally thought that each service would need a reminder to set itself as the static PrefService... but that's exactly what the initialize method of AbstractPrefService is for.
1 parent f857d0f commit a9a109c

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

src/main/java/org/scijava/preferences/AbstractPrefService.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@
3535
import org.scijava.util.Prefs;
3636

3737
/**
38-
* Abstract {@link PrefService} implementation. Provides a basic
39-
* {@link #setStaticBehavior()} implementation, calling it during service
40-
* {@link #initialize()} to set this as the delegate service.
38+
* Abstract {@link PrefService} implementation. Calls
39+
* {@link Prefs#setDelegateService(PrefService, double)} on this {@code Service}
40+
* during initialization.
4141
*
4242
* @author Mark Hiner
4343
*/
@@ -47,12 +47,6 @@ public abstract class AbstractPrefService extends AbstractService implements
4747

4848
@Override
4949
public void initialize() {
50-
setStaticBehavior();
51-
}
52-
53-
@Override
54-
public void setStaticBehavior() {
5550
Prefs.setDelegateService(this, getPriority());
5651
}
57-
5852
}

src/main/java/org/scijava/preferences/PrefService.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,4 @@ public interface PrefService extends SciJavaService {
144144
* prefs.
145145
*/
146146
List<String> getList(Preferences preferences);
147-
148-
/**
149-
* Updates the behavior of the {@link org.scijava.util.Prefs} static utility
150-
* class to use delegate to this service.
151-
*/
152-
void setStaticBehavior();
153147
}

0 commit comments

Comments
 (0)