Make use of the new createTemporaryDirectory() method in our own tests

The benefits are obvious: should Jenkins report failures in one of
these tests, we can easily inspect those temporary directories because
they are now written into the target/ directory (which Jenkins makes
visible, in contrast to /tmp/).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

src/test/java/org/scijava/annotations/EclipseHelperTest.java

@@ -34,6 +34,7 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
+import static org.scijava.test.TestUtils.createTemporaryDirectory;
 
 import java.io.File;
 import java.io.FileOutputStream;
@@ -54,7 +55,7 @@ public class EclipseHelperTest {
 
 	@Test
 	public void testSkipIndexGeneration() throws Exception {
-		final File dir = createTempDirectory();
+		final File dir = createTemporaryDirectory("eclipse-test-");
 		copyClasses(dir, Complex.class, Simple.class);
 		final File jsonDir = new File(dir, Index.INDEX_PREFIX);
 		assertFalse(jsonDir.exists());
@@ -68,7 +69,7 @@ public void testSkipIndexGeneration() throws Exception {
 
 	@Test
 	public void testIndexing() throws Exception {
-		final File dir = createTempDirectory();
+		final File dir = createTemporaryDirectory("eclipse-test-");
 		copyClasses(dir, Complex.class, Simple.class, Fruit.class,
 			AnnotatedA.class, AnnotatedB.class, AnnotatedC.class);
 		final File jsonDir = new File(dir, Index.INDEX_PREFIX);
@@ -144,46 +145,4 @@ private void copyClasses(final File dir, final Class<?>... classes)
 		}
 	}
 
-	private File createTempDirectory() throws IOException {
-		// if running from .../target/test-classes/, let's make a directory next to
-		// it
-		final String classPath =
-			"/" + DirectoryIndexerTest.getResourcePath(getClass());
-		final String url = getClass().getResource(classPath).toString();
-		if (url.startsWith("file:") && url.endsWith(classPath)) {
-			final String directory =
-				url.substring(5, url.length() - classPath.length());
-			if (directory.endsWith("/target/test-classes")) {
-				final File testClassesDirectory = new File(directory);
-				if (testClassesDirectory.isDirectory()) {
-					final File result =
-						new File(testClassesDirectory.getParentFile(), "eclipse test");
-					if (result.exists()) {
-						rmRF(result);
-					}
-					return result;
-				}
-			}
-		}
-		// fall back to /tmp/
-		final File result = File.createTempFile("eclipse test", "");
-		result.delete();
-		result.mkdir();
-		return result;
-	}
-
-	private static boolean rmRF(final File directory) {
-		final File[] list = directory.listFiles();
-		if (list != null) {
-			for (final File file : list) {
-				if (file.isFile() && !file.delete()) {
-					return false;
-				}
-				else if (file.isDirectory() && !rmRF(file)) {
-					return false;
-				}
-			}
-		}
-		return directory.delete();
-	}
 }

src/test/java/org/scijava/util/ClassUtilsTest.java

@@ -35,6 +35,7 @@
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertSame;
 import static org.junit.Assert.assertTrue;
+import static org.scijava.test.TestUtils.createTemporaryDirectory;
 
 import java.io.File;
 import java.io.FileOutputStream;
@@ -171,7 +172,7 @@ public void testGetGenericType() {
 
 	@Test
 	public void testUnpackedClass() throws IOException {
-		final File tmpDir = FileUtils.createTemporaryDirectory("class-utils-test", "");
+		final File tmpDir = createTemporaryDirectory("class-utils-test-");
 		final String path = getClass().getName().replace('.', '/') + ".class";
 		final File classFile = new File(tmpDir, path);
 		assertTrue(classFile.getParentFile().exists() ||
@@ -189,7 +190,8 @@ public void testUnpackedClass() throws IOException {
 
 	@Test
 	public void testClassInJar() throws IOException {
-		final File jar = File.createTempFile("class-utils-test", ".jar");
+		final File tmpDir = createTemporaryDirectory("class-utils-test-");
+		final File jar = new File(tmpDir, "test.jar");
 		final JarOutputStream out = new JarOutputStream(new FileOutputStream(jar));
 		final String path = getClass().getName().replace('.', '/') + ".class";
 		out.putNextEntry(new ZipEntry(path));

src/test/java/org/scijava/util/FileUtilsTest.java

@@ -36,6 +36,7 @@
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
+import static org.scijava.test.TestUtils.createTemporaryDirectory;
 
 import java.io.File;
 import java.io.FileNotFoundException;
@@ -201,7 +202,8 @@ public void testListContents() throws IOException, URISyntaxException {
 		// write some items to a temporary .jar file
 		final String subDir = "sub 𝄞directory/";
 		final String subSubDir = "more 𝄢stuff/";
-		final File jarFile = File.createTempFile("listContentsTest", ".jar");
+		final File tmpDir = createTemporaryDirectory("file-utils-test-");
+		final File jarFile = new File(tmpDir, "listContentsTest.jar");
 		final FileOutputStream out = new FileOutputStream(jarFile);
 		final JarOutputStream jarOut = new JarOutputStream(out);
 		try {
@@ -292,7 +294,7 @@ public void testGetAllVersions() throws IOException {
 		final String withClassifier = "miglayout-3.7.3.1-swing.jar";
 		final String withoutClassifier = "miglayout-3.7.3.1.jar";
 
-		final File tmp = FileUtils.createTemporaryDirectory("delete-other-", "");
+		final File tmp = createTemporaryDirectory("delete-other-");
 		try {
 			writeEmptyFile(new File(tmp, withClassifier));
 			writeEmptyFile(new File(tmp, withoutClassifier));