Commit 30e52ca
committed
Stop assigning ConversionUtils delegates
This logic is inherently unsound, because it pollutes static state.
It changes the behavior of the ConversionUtils methods depending on
whether a SciJava Context with a ConvertService has ever been
instantiated, and depending on the available Converter plugins.
With this logic removed, all tests now pass, and pass more consistently,
wheras before, the ConversionUtilsTest would have all passing tests when
run standalone, and failing test(s) when run as part of the suite.
I'm aware that this change may break some things downstream. But because
no unit tests exist here in scijava-common to catch those theoretical
cases, we will just have to give it a try by making a release, and then
address any issues arising afterward.1 parent b483075 commit 30e52ca
File tree
1 file changed
+5
-12
lines changed- src/main/java/org/scijava/convert
1 file changed
+5
-12
lines changedLines changed: 5 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | 39 | | |
41 | 40 | | |
42 | | - | |
43 | | - | |
| 41 | + | |
44 | 42 | | |
45 | 43 | | |
46 | 44 | | |
47 | | - | |
48 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | 162 | | |
170 | 163 | | |
171 | 164 | | |
| |||
0 commit comments