#158 - Test CppStringT::removesuffix() with char and wchar_t

Completed. Fixed a bug on size of substring.

Author: schmouk

cpp-strings-tests/cpp-strings-tests.cpp

@@ -893,5 +893,22 @@ namespace cppstringstests
 			Assert::AreEqual(L"cdab", L"abcdab"cs.removeprefix(L"ab").c_str());
 		}
 
+
+		TEST_METHOD(removesuffix)
+		{
+			pcs::CppString s("abcd");
+			Assert::AreEqual("ab", s.removesuffix("cd").c_str());
+			Assert::AreEqual("abcd", s.removesuffix("dc").c_str());
+			Assert::AreEqual("abcd", s.removesuffix("").c_str());
+			Assert::AreEqual("abbaba", "abbabaabcd"cs.removesuffix("abcd").c_str());
+			Assert::AreEqual("abcd", "abcdab"cs.removesuffix("ab").c_str());
+
+			pcs::CppWString ws(L"abcd");
+			Assert::AreEqual(L"ab", ws.removesuffix(L"cd").c_str());
+			Assert::AreEqual(L"abcd", ws.removesuffix(L"dc").c_str());
+			Assert::AreEqual(L"abcd", ws.removesuffix(L"").c_str());
+			Assert::AreEqual(L"abbaba", L"abbabaabcd"cs.removesuffix(L"abcd").c_str());
+			Assert::AreEqual(L"abcd", L"abcdab"cs.removesuffix(L"ab").c_str());
+		}
 	};
 }

cpp-strings/cppstrings.h

@@ -1174,7 +1174,7 @@ namespace pcs // i.e. "pythonic c++ strings"
         {
             if (this->endswith(suffix)) {
                 const size_type suffix_length = suffix.size();
-                return this->substr(0, this->size() - suffix_length + 1);
+                return this->substr(0, this->size() - suffix_length);
             }
             else
                 return *this;