#151 - Test CppStringT::is_words_sep() with char and wchar_t

Tested.

Author: schmouk

cpp-strings-tests/cpp-strings-tests.cpp

@@ -696,5 +696,24 @@ namespace cppstringstests
 			}
 		}
 
+		TEST_METHOD(is_words_sep)
+		{
+			Assert::IsFalse(CppString().is_words_sep());
+			for (int c = 32; c <= 255; ++c) {
+				const char ch{ char(c) };
+				pcs::CppString s(5, ch);
+				Assert::AreEqual(pcs::is_space(ch) || pcs::is_punctuation(ch), s.is_words_sep());
+			}
+
+			Assert::IsFalse(CppWString().is_words_sep());
+			for (int c = 0; c <= 0xffff; ++c) {
+				const wchar_t wch{ wchar_t(c) };
+				pcs::CppWString ws(5, wch);
+				Assert::AreEqual(pcs::is_space(wch) || pcs::is_punctuation(wch), ws.is_words_sep());
+			}
+		}
+
+
+
 	};
 }

cpp-strings/cppstrings.h

@@ -1005,7 +1005,8 @@ namespace pcs // i.e. "pythonic c++ strings"
         /** \brief Returns true if there are only whitespace and punctuation characters in the string and there is at least one character, or false otherwise. */
         inline const bool is_words_sep() const noexcept
         {
-            return isspace() || ispunctuation();
+            return !this->empty() && std::all_of(this->cbegin(), this->cend(),
+                                                 [](const value_type ch){ return pcs::is_space(ch) || pcs::is_punctuation(ch); });
         }