Skip to content
This repository was archived by the owner on Apr 11, 2019. It is now read-only.

Commit 6d05934

Browse files
committed
Merge branch 'master' into feat_rc_server_rendering
2 parents 2ae3413 + 08f418d commit 6d05934

File tree

14 files changed

+46
-7873
lines changed

14 files changed

+46
-7873
lines changed

README.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,13 @@ If this is confusing, don't fret, we've set you up with a few examples and code
2222
Below are a few example apps that have been built with this project
2323
- React Weekly
2424
- [See the Code](https://github.com/RyanCCollins/react-weekly)
25-
- [See the App](http://www.reactweekly.co/)
25+
- [See the Live App](http://www.reactweekly.co/)
2626
- Restaurant Reviewer
2727
- [See the Code](https://github.com/RyanCCollins/restaurant-reviewer)
28-
- [See the Working App](http://restaurant-reviewer-client.herokuapp.com/)
28+
- [See the Live App](http://restaurant-reviewer-client.herokuapp.com/)
29+
- Corporate Dashboard
30+
- [See the Code](https://github.com/RyanCCollins/corporate-dashboard)
31+
- [See the Live App](https://corporate-dashboard-client.herokuapp.com/)
2932

3033
## Experimental Features
3134
### Server Rendering
@@ -242,7 +245,7 @@ which will pick up any file with the .test.js postfix and run it through Karma /
242245
* [x] Add Webpack stats plugin
243246
* [x] Dogfood the project and iterate on suggestions
244247
* [x] Setup production server configuration
245-
* [ ] Add Jest as testing utility
248+
* [x] Add Jest as testing utility
246249
* [ ] Create Docker container & automation scripts
247250
* [ ] Write wiki / other documentation
248251

app/src/components/Navbar/index.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import React from 'react';
2-
import Header from 'grommet/components/Header';
3-
import Title from 'grommet/components/Title';
4-
import Menu from 'grommet/components/Menu';
5-
import Anchor from 'grommet/components/Anchor';
6-
import Search from 'grommet/components/Search';
2+
import Header from 'grommet-udacity/components/Header';
3+
import Title from 'grommet-udacity/components/Title';
4+
import Menu from 'grommet-udacity/components/Menu';
5+
import Anchor from 'grommet-udacity/components/Anchor';
6+
import Search from 'grommet-udacity/components/Search';
77
import LogoImage from './logo.png';
88

99
import styles from './index.module.scss';

app/src/components/Navbar/tests/__snapshots__/index.test.js.snap

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ exports[`<Navbar /> should render with default props 1`] = `
1111
"vertical": "none"
1212
}
1313
}
14-
responsive={false}
15-
tag="header">
14+
responsive={false}>
1615
<Title
1716
responsive={true}>
1817
<img

app/src/containers/FeatureFirstContainer/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ FeatureFirstContainer.propTypes = {
5757

5858
// mapStateToProps :: {State} -> {Action}
5959
const mapStateToProps = (state) => ({
60-
isLoading: state.isLoading,
60+
isLoading: state.featureComponent.isLoading,
6161
});
6262

6363
// mapDispatchToProps :: Dispatch Func -> {Actions}

app/src/containers/FeatureFirstContainer/tests/__snapshots__/index.test.js.snap

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,14 @@ exports[`<FeatureFirstContainer /> renders with default props 1`] = `
88
"loadDataSuccess": [Function anonymous]
99
}
1010
}
11+
isLoading={false}
1112
store={
1213
Object {
1314
"clearActions": [Function clearActions],
1415
"dispatch": [Function anonymous],
1516
"getActions": [Function getActions],
1617
"getState": [Function getState],
18+
"replaceReducer": [Function replaceReducer],
1719
"subscribe": [Function subscribe]
1820
}
1921
} />

0 commit comments

Comments
 (0)