[BUG] Refactor formula to align args / environment handling #62
Description
Your setup
Formula commit hash / release tag
n/a
Versions reports (master & minion)
n/a
Pillar / config used
repo pillar within formula.
Bug details
Describe the bug
The current implementation has a range of potentially duplicate pillars for handling command ARGs.
Such as:
service:
args:
environ:
args:
environ_config:
args_file:
The benefit of these duplicates are unclear though they appear to be used in different parts of the formula. This however results in necessity to duplicate work and potential confusion with implementation.
Steps to reproduce the bug
n/a
Expected behaviour
Align the approach to ARG handling at least as far as the pillar is concerned.
Attempts to fix the bug
Pull #60 followed guidance to deliver the solution using the environ file rather than implementing through services, which appears to be the most consistent approach considering best practice and the package maintainers intentions.