fix: lint member-ordering, restrict-template-expressions, no-underscore-dangle, numeric-separators

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: ankitsinghkuntal09

src/server/DevServerManager.ts

@@ -106,6 +106,10 @@ type DevServerConfig = {
  * ```
  */
 export class DevServerManager extends EventEmitter {
+  // AC2: PID file path for orphaned-process recovery (CLI / Code Builder) — static before instance per member-ordering
+  private static readonly PID_DIR = '.sf';
+  private static readonly PID_FILENAME = 'webapp-dev-server.pid';
+
   private options: DevServerConfig;
   private process: ChildProcess | null = null;
   private detectedUrl: string | null = null;
@@ -115,10 +119,6 @@ export class DevServerManager extends EventEmitter {
   private stderrBuffer: string[] = []; // Buffer to store stderr lines for error parsing
   private readonly maxStderrLines = 100; // Keep last 100 lines
 
-  // AC2: PID file path for orphaned-process recovery (CLI / Code Builder)
-  private static readonly PID_DIR = '.sf';
-  private static readonly PID_FILENAME = 'webapp-dev-server.pid';
-
   /**
    * Creates a new DevServerManager instance
    *
@@ -130,48 +130,6 @@ export class DevServerManager extends EventEmitter {
     this.logger = Logger.childFromRoot('DevServerManager');
   }
 
-  // --- AC2: PID file persistence (for CLI / direct browser path) ---
-
-  /**
-   * Get the PID file path. Uses the project root's .sf/ directory.
-   */
-  private getPidFilePath(): string {
-    return join(this.options.cwd, DevServerManager.PID_DIR, DevServerManager.PID_FILENAME);
-  }
-
-  /**
-   * Save the dev server PID to a file on disk.
-   * This allows orphan cleanup if the CLI process crashes or Code Builder disconnects.
-   */
-  private savePidFile(pid: number): void {
-    try {
-      const dir = join(this.options.cwd, DevServerManager.PID_DIR);
-      if (!existsSync(dir)) {
-        mkdirSync(dir, { recursive: true });
-      }
-      const pidData = JSON.stringify({ pid, url: this.detectedUrl, timestamp: Date.now() });
-      writeFileSync(this.getPidFilePath(), pidData, 'utf-8');
-      this.logger.debug(`Saved dev server PID file: ${pid}`);
-    } catch (error) {
-      this.logger.warn(`Failed to write PID file: ${error instanceof Error ? error.message : String(error)}`);
-    }
-  }
-
-  /**
-   * Remove the PID file (on clean shutdown).
-   */
-  private removePidFile(): void {
-    try {
-      const pidPath = this.getPidFilePath();
-      if (existsSync(pidPath)) {
-        unlinkSync(pidPath);
-        this.logger.debug('Removed dev server PID file');
-      }
-    } catch (error) {
-      this.logger.warn(`Failed to remove PID file: ${error instanceof Error ? error.message : String(error)}`);
-    }
-  }
-
   /**
    * Read saved PID from the PID file.
    * Returns null if no PID file exists or it's unreadable.
@@ -214,7 +172,7 @@ export class DevServerManager extends EventEmitter {
       return false;
     }
 
-    logger?.debug(`Found saved PID file: PID=${saved.pid}, URL=${saved.url}`);
+    logger?.debug(`Found saved PID file: PID=${saved.pid}, URL=${String(saved.url ?? 'null')}`);
 
     try {
       // Signal 0 just checks if the process exists
@@ -252,13 +210,6 @@ export class DevServerManager extends EventEmitter {
     return false;
   }
 
-  /**
-   * Get the PID of the running dev server process (if any).
-   */
-  public getPid(): number | undefined {
-    return this.process?.pid ?? undefined;
-  }
-
   /**
    * Strips ANSI color codes from a string
    *
@@ -304,6 +255,13 @@ export class DevServerManager extends EventEmitter {
     return null;
   }
 
+  /**
+   * Get the PID of the running dev server process (if any).
+   */
+  public getPid(): number | undefined {
+    return this.process?.pid ?? undefined;
+  }
+
   /**
    * Starts the dev server process
    *
@@ -431,6 +389,46 @@ export class DevServerManager extends EventEmitter {
     });
   }
 
+  /**
+   * Get the PID file path. Uses the project root's .sf/ directory.
+   */
+  private getPidFilePath(): string {
+    return join(this.options.cwd, DevServerManager.PID_DIR, DevServerManager.PID_FILENAME);
+  }
+
+  /**
+   * Save the dev server PID to a file on disk.
+   * This allows orphan cleanup if the CLI process crashes or Code Builder disconnects.
+   */
+  private savePidFile(pid: number): void {
+    try {
+      const dir = join(this.options.cwd, DevServerManager.PID_DIR);
+      if (!existsSync(dir)) {
+        mkdirSync(dir, { recursive: true });
+      }
+      const pidData = JSON.stringify({ pid, url: this.detectedUrl, timestamp: Date.now() });
+      writeFileSync(this.getPidFilePath(), pidData, 'utf-8');
+      this.logger.debug(`Saved dev server PID file: ${pid}`);
+    } catch (error) {
+      this.logger.warn(`Failed to write PID file: ${error instanceof Error ? error.message : String(error)}`);
+    }
+  }
+
+  /**
+   * Remove the PID file (on clean shutdown).
+   */
+  private removePidFile(): void {
+    try {
+      const pidPath = this.getPidFilePath();
+      if (existsSync(pidPath)) {
+        unlinkSync(pidPath);
+        this.logger.debug('Removed dev server PID file');
+      }
+    } catch (error) {
+      this.logger.warn(`Failed to remove PID file: ${error instanceof Error ? error.message : String(error)}`);
+    }
+  }
+
   /**
    * Sets up event handlers for the spawned process
    *

test/proxy/ProxyServer.test.ts

@@ -267,7 +267,7 @@ describe('ProxyServer', () => {
   });
 
   describe('Proxy API (_proxy/*) – W-20243732', () => {
-    const API_PORT = 19545;
+    const API_PORT = 19_545;
     let proxy: ProxyServer | null = null;
 
     afterEach(async function () {

test/server/resolveDevCommand.test.ts

@@ -20,8 +20,8 @@ import { fileURLToPath } from 'node:url';
 import { expect } from 'chai';
 import { parseCommand, resolveDirectDevCommand } from '../../src/server/resolveDevCommand.js';
 
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const FIXTURE_RESOLVE = join(__dirname, '../fixtures/dev-server-resolve');
+const currentDir = dirname(fileURLToPath(import.meta.url));
+const FIXTURE_RESOLVE = join(currentDir, '../fixtures/dev-server-resolve');
 
 describe('resolveDevCommand (W-20243732)', () => {
   describe('parseCommand', () => {