refactor: remove dead code and optimize for readability

- Remove unreachable createGenericError method in DevServerErrorParser
  (catch-all regex pattern /.*/ makes fallback code unreachable)
- Extract resolveWebappName helper to eliminate duplicate name priority logic
- Remove redundant dot-prefixed entries from EXCLUDED_DIRECTORIES
  (already handled by startsWith('.') check)
- Optimize handleProcessOutput to split lines once instead of twice

Author: deepu-mungamuri94

src/config/webappDiscovery.ts

@@ -55,22 +55,10 @@ export type DiscoveredWebapp = {
 };
 
 /**
- * Directories to exclude when processing webapplications folder
+ * Directories to exclude when processing webapplications folder.
+ * Note: Directories starting with '.' are excluded separately in shouldExcludeDirectory()
  */
-const EXCLUDED_DIRECTORIES = new Set([
-  'node_modules',
-  '.git',
-  'dist',
-  'build',
-  'out',
-  'coverage',
-  '.next',
-  '.nuxt',
-  '.output',
-  '__pycache__',
-  '.venv',
-  'venv',
-]);
+const EXCLUDED_DIRECTORIES = new Set(['node_modules', 'dist', 'build', 'out', 'coverage', '__pycache__', 'venv']);
 
 /**
  * Check if a directory should be excluded from processing
@@ -137,6 +125,21 @@ async function tryParseWebappManifest(filePath: string): Promise<WebAppManifest
   }
 }
 
+/**
+ * Resolve webapp name using priority: manifest.name > metaXmlName > folderName
+ *
+ * @param folderName - The folder name (fallback)
+ * @param metaXmlName - Name extracted from .webapplication-meta.xml (or null)
+ * @param manifest - Parsed manifest (or null)
+ * @returns The resolved webapp name
+ */
+function resolveWebappName(folderName: string, metaXmlName: string | null, manifest: WebAppManifest | null): string {
+  if (manifest?.name && typeof manifest.name === 'string' && manifest.name.trim()) {
+    return manifest.name;
+  }
+  return metaXmlName ?? folderName;
+}
+
 /**
  * Try to resolve SFDX project root from a given directory.
  * Uses SfProject from @salesforce/core which walks up directories to find sfdx-project.json.
@@ -252,19 +255,11 @@ async function discoverWebappsInFolder(webappsFolderPath: string, cwd: string):
       // Try to load manifest for dev configuration
       const manifest = await tryParseWebappManifest(manifestFilePath);
 
-      // Name priority: manifest.name > meta.xml name > folder name
-      let webappName = entry.name;
-      if (manifest?.name && typeof manifest.name === 'string' && manifest.name.trim()) {
-        webappName = manifest.name;
-      } else if (metaXmlName) {
-        webappName = metaXmlName;
-      }
-
       return {
         path: webappPath,
         relativePath: relative(cwd, webappPath) || entry.name,
         manifest,
-        name: webappName,
+        name: resolveWebappName(entry.name, metaXmlName, manifest),
         hasManifest: manifest !== null,
         manifestPath: manifest ? manifestFilePath : null,
         hasMetaXml: true,
@@ -340,14 +335,7 @@ async function findAllWebapps(cwd: string = process.cwd()): Promise<FindAllWebap
       // Current directory is a standalone webapp
       const manifestFilePath = join(cwd, 'webapplication.json');
       const manifest = await tryParseWebappManifest(manifestFilePath);
-
-      // Name priority: manifest.name > meta.xml name > folder name
-      let webappName = basename(cwd);
-      if (manifest?.name && typeof manifest.name === 'string' && manifest.name.trim()) {
-        webappName = manifest.name;
-      } else if (metaXmlName) {
-        webappName = metaXmlName;
-      }
+      const webappName = resolveWebappName(basename(cwd), metaXmlName, manifest);
 
       const standaloneWebapp: DiscoveredWebapp = {
         path: cwd,

src/error/DevServerErrorParser.ts

@@ -189,8 +189,9 @@ export class DevServerErrorParser {
       }
     }
 
-    // Fallback (should never reach here due to catch-all pattern)
-    return this.createGenericError(stderr, exitCode, signal);
+    // This point is unreachable because the last pattern (.*) matches everything
+    // TypeScript requires a return statement, so we throw an error for safety
+    throw new Error('Unreachable: ERROR_PATTERNS catch-all should always match');
   }
 
   /**
@@ -216,29 +217,4 @@ export class DevServerErrorParser {
     // Return last N lines (most recent errors)
     return lines.slice(-maxLines);
   }
-
-  /**
-   * Create a generic error when no specific pattern matches
-   *
-   * @param stderr - Full stderr output
-   * @param exitCode - Process exit code
-   * @param signal - Process exit signal
-   * @returns Generic DevServerError
-   */
-  private static createGenericError(stderr: string, exitCode?: number | null, signal?: string | null): DevServerError {
-    return {
-      type: 'unknown',
-      title: 'Dev Server Failed to Start',
-      message: 'The dev server encountered an error. Check the error output below for details.',
-      stderrLines: this.extractRelevantLines(stderr, 15),
-      suggestions: [
-        'Review the error output above',
-        'Try running your dev command manually to debug',
-        'Verify your project setup is correct',
-      ],
-      fullStderr: stderr,
-      exitCode,
-      signal,
-    };
-  }
 }

src/server/DevServerManager.ts

@@ -346,9 +346,11 @@ export class DevServerManager extends EventEmitter {
     // Emit output event for consumers
     this.emit(stream, output);
 
+    // Split lines once and reuse for all operations
+    const lines = output.split('\n').filter((line) => line.trim());
+
     // Capture stderr lines for error parsing
     if (stream === 'stderr') {
-      const lines = output.split('\n').filter((line) => line.trim());
       this.stderrBuffer.push(...lines);
 
       // Keep only the last N lines to prevent memory issues
@@ -358,7 +360,6 @@ export class DevServerManager extends EventEmitter {
     }
 
     // Log dev server output (only visible when SF_LOG_LEVEL=debug)
-    const lines = output.split('\n').filter((line) => line.trim());
     for (const line of lines) {
       this.logger.debug(`[Dev Server ${stream}] ${line}`);
     }