Merge pull request #1068 from salesforcecli/hc/check-recommended-version-id-ancestry

W-19900152 - check recommended version ancestry

Author: shetzel

README.md

@@ -808,6 +808,8 @@ FLAGS
       --api-version=<value>                  Override the api version used for api requests made by this command
       --[no-]enable-app-analytics            Enable AppExchange App Analytics usage data collection on this managed
                                              package and its components.
+      --skip-ancestor-check                  Bypass checking that the new recommended version is an ancestor of the
+                                             previous recommended version.
 
 GLOBAL FLAGS
   --flags-dir=<value>  Import flag values from a directory.

command-snapshot.json

@@ -375,7 +375,8 @@
       "name",
       "package",
       "target-dev-hub",
-      "recommended-version-id"
+      "recommended-version-id",
+      "skip-ancestor-check"
     ],
     "plugin": "@salesforce/plugin-packaging"
   },

messages/package_update.md

@@ -45,3 +45,7 @@ Package version ID that subscribers are notified to install or upgrade to.
 # flags.recommended-version-id.description
 
 Specify the recommended package version for subscribers to install. Subscribers are notified to install the package version ID that you specify. If the subscribers have a different version of the same package installed, they're notified to upgrade to the recommended version.
+
+# flags.skip-ancestor-check.summary
+
+Bypass the ancestry check for setting a recommended version.

package.json

@@ -8,7 +8,7 @@
     "@oclif/core": "^4",
     "@salesforce/core": "^8.23.2",
     "@salesforce/kit": "^3.2.4",
-    "@salesforce/packaging": "^4.16.0",
+    "@salesforce/packaging": "^4.17.0",
     "@salesforce/sf-plugins-core": "^12.2.4",
     "chalk": "^5.6.2"
   },

src/commands/package/update.ts

@@ -64,6 +64,9 @@ export class PackageUpdateCommand extends SfCommand<PackageSaveResult> {
       summary: messages.getMessage('flags.recommended-version-id.summary'),
       description: messages.getMessage('flags.recommended-version-id.description'),
     }),
+    'skip-ancestor-check': Flags.boolean({
+      summary: messages.getMessage('flags.skip-ancestor-check.summary'),
+    }),
   };
 
   public async run(): Promise<PackageSaveResult> {
@@ -75,14 +78,17 @@ export class PackageUpdateCommand extends SfCommand<PackageSaveResult> {
       project: await maybeGetProject(),
     });
 
-    const result = await pkg.update({
-      Id: pkg.getId(),
-      Name: flags.name,
-      Description: flags.description,
-      PackageErrorUsername: flags['error-notification-username'],
-      AppAnalyticsEnabled: flags['enable-app-analytics'],
-      RecommendedVersionId: flags['recommended-version-id'],
-    });
+    const result = await pkg.update(
+      {
+        Id: pkg.getId(),
+        Name: flags.name,
+        Description: flags.description,
+        PackageErrorUsername: flags['error-notification-username'],
+        AppAnalyticsEnabled: flags['enable-app-analytics'],
+        RecommendedVersionId: flags['recommended-version-id'],
+      },
+      flags['skip-ancestor-check']
+    );
 
     this.logSuccess(messages.getMessage('success', [pkg.getId()]));
 

yarn.lock

@@ -1616,7 +1616,7 @@
     "@jridgewell/resolve-uri" "^3.1.0"
     "@jridgewell/sourcemap-codec" "^1.4.14"
 
-"@jsforce/jsforce-node@^3.10.4", "@jsforce/jsforce-node@^3.10.8":
+"@jsforce/jsforce-node@^3.10.8":
   version "3.10.8"
   resolved "https://registry.yarnpkg.com/@jsforce/jsforce-node/-/jsforce-node-3.10.8.tgz#f13903a0885fa3501a513512984cf9a717aebb9a"
   integrity sha512-XGD/ivZz+htN5SgctFyEZ+JNG6C8FXzaEwvPbRSdsIy/hpWlexY38XtTpdT5xX3KnYSnOE4zA1M/oIbTm7RD/Q==
@@ -1827,7 +1827,7 @@
     strip-ansi "6.0.1"
     ts-retry-promise "^0.8.1"
 
-"@salesforce/core@^8.18.7", "@salesforce/core@^8.23.0", "@salesforce/core@^8.23.1", "@salesforce/core@^8.23.2", "@salesforce/core@^8.5.1", "@salesforce/core@^8.8.0":
+"@salesforce/core@^8.18.7", "@salesforce/core@^8.23.1", "@salesforce/core@^8.23.2", "@salesforce/core@^8.5.1", "@salesforce/core@^8.8.0":
   version "8.23.2"
   resolved "https://registry.yarnpkg.com/@salesforce/core/-/core-8.23.2.tgz#218152b97e05745cd0499ad2594df4443fa8aa18"
   integrity sha512-9XUlaI0orvdjDJZsgjt0lVLa5wrFWNaorRbshT/EJ6fIiqcAehOV2bR62NJtRhrOrgu1h34bTmUqMo+yUEES9w==
@@ -1896,16 +1896,16 @@
   dependencies:
     "@salesforce/ts-types" "^2.0.12"
 
-"@salesforce/packaging@^4.16.0":
-  version "4.16.0"
-  resolved "https://registry.yarnpkg.com/@salesforce/packaging/-/packaging-4.16.0.tgz#e7ba298a7e00c5dc72a21b6764ff2c9a8a5e82fc"
-  integrity sha512-B9pNih9LpISVqKJWQ/dN9SKsppqrOXMECiGxEq+x4NZPV9Rgf9HJEpJL17LkI2KGynKwL+Hpflo9zMeiZ6JzJQ==
+"@salesforce/packaging@^4.17.0":
+  version "4.17.0"
+  resolved "https://registry.yarnpkg.com/@salesforce/packaging/-/packaging-4.17.0.tgz#809491060b26a71c4a736879154d20215c216796"
+  integrity sha512-3RA14IxY3RsCHLdEgLAdUTdwEzllcowRuVGWOSFw6XrpEJ779vZl+JfEVAklPwQWZGrEsNzhUf34FFrewtbchw==
   dependencies:
-    "@jsforce/jsforce-node" "^3.10.4"
-    "@salesforce/core" "^8.23.0"
+    "@jsforce/jsforce-node" "^3.10.8"
+    "@salesforce/core" "^8.23.2"
     "@salesforce/kit" "^3.2.3"
     "@salesforce/schemas" "^1.10.3"
-    "@salesforce/source-deploy-retrieve" "^12.16.9"
+    "@salesforce/source-deploy-retrieve" "^12.24.0"
     "@salesforce/ts-types" "^2.0.11"
     "@salesforce/types" "^1.2.0"
     fast-xml-parser "^4.5.0"
@@ -1974,15 +1974,15 @@
     cli-progress "^3.12.0"
     terminal-link "^3.0.0"
 
-"@salesforce/source-deploy-retrieve@^12.16.9":
-  version "12.24.0"
-  resolved "https://registry.yarnpkg.com/@salesforce/source-deploy-retrieve/-/source-deploy-retrieve-12.24.0.tgz#cc4e38175436aeb6c9c22ee795924c96d7ef87c8"
-  integrity sha512-gjS6whT1575UGxwR2foDILlsbDQPwng0rNyXsk39hwg+bRsbHABZGzxU5EeUIzpKqv4bf6C9z/BLYiHMcZocoQ==
+"@salesforce/source-deploy-retrieve@^12.24.0":
+  version "12.24.3"
+  resolved "https://registry.yarnpkg.com/@salesforce/source-deploy-retrieve/-/source-deploy-retrieve-12.24.3.tgz#125be3a3e6d0d0f21068648ce4a2e4bb49ea57b6"
+  integrity sha512-MTpilWa+1mOqZUEmbE7K/vgHAT0FjGDv9L6vn7Cof3kRhk3RZprIjR6Sd9/x1WteI+hR5JAMCDbKT/WiWJcKYw==
   dependencies:
-    "@salesforce/core" "^8.23.1"
-    "@salesforce/kit" "^3.2.3"
+    "@salesforce/core" "^8.23.2"
+    "@salesforce/kit" "^3.2.4"
     "@salesforce/ts-types" "^2.0.12"
-    "@salesforce/types" "^1.4.0"
+    "@salesforce/types" "^1.5.0"
     fast-levenshtein "^3.0.0"
     fast-xml-parser "^4.5.3"
     got "^11.8.6"
@@ -1999,11 +1999,16 @@
   resolved "https://registry.yarnpkg.com/@salesforce/ts-types/-/ts-types-2.0.12.tgz#60420622812a7ec7e46d220667bc29b42dc247ff"
   integrity sha512-BIJyduJC18Kc8z+arUm5AZ9VkPRyw1KKAm+Tk+9LT99eOzhNilyfKzhZ4t+tG2lIGgnJpmytZfVDZ0e2kFul8g==
 
-"@salesforce/types@^1.2.0", "@salesforce/types@^1.4.0":
+"@salesforce/types@^1.2.0":
   version "1.4.0"
   resolved "https://registry.yarnpkg.com/@salesforce/types/-/types-1.4.0.tgz#a8b8baa0b7cc9cb6718379464d9bc9e4ab834e9e"
   integrity sha512-WpXzQd+JglQrwUs05ePGa1/vFFn1s7rymw2ltBbFj2Z0p/ez1ft6J39ILVlteS/mGca47Ce8JN+u3USVxfxkKA==
 
+"@salesforce/types@^1.5.0":
+  version "1.5.0"
+  resolved "https://registry.yarnpkg.com/@salesforce/types/-/types-1.5.0.tgz#dd1db8651ae9729c133ee5224ec7fbf50b1087ad"
+  integrity sha512-zBihdJ6WwE0JP6BVCXhm7guMQlj4/7nCYqtrkozgxgeKLJq+zKrTRwILeRQbbeqVP4nKjUz/AJr0zCDjrA2IVg==
+
 "@shikijs/core@1.29.2":
   version "1.29.2"
   resolved "https://registry.yarnpkg.com/@shikijs/core/-/core-1.29.2.tgz#9c051d3ac99dd06ae46bd96536380c916e552bf3"