feat: use the right LWC/Dev server version for the org @W-20405334@ by abdulsattar · Pull Request #596 · salesforcecli/plugin-lightning-dev

abdulsattar · 2026-01-13T20:13:42Z

What does this PR do?

Implements Phase 1 of https://github.com/salesforcecli/plugin-lightning-dev/blob/nkruk/single-install-design/DUAL_VERSION_DESIGN.md

What issues does this PR fix or reference?

@W-20405334@

nrkruk · 2026-01-14T18:26:55Z

@abdulsattar I setup a quick call for us to review this PR today - I just want to ensure things are working as expected. Let me know if that time works

…rror handling

abdulsattar

Nick and Brian review.

abdulsattar · 2026-01-14T21:05:52Z

+        "dependencies": {
+          "@lwc/lwc-dev-server": "~13.2.x",
+          "@lwc/sfdc-lwc-compiler": "~13.2.x",
+          "lwc": "~8.23.x"


Do we need 'lwc'?

Check the bundle size.

abdulsattar · 2026-01-14T21:10:01Z


+# flags.version-channel.summary
+
+Manually specify which version channel to use (latest, prerelease, or next).


Nick: SFDX already has the api version command. Use that instead of version-channel.

Verify how @lwc/compiler in peerDependencies in lwc-dev-server work.

Nick: Create a new package that imports lwc-dev-server and @lwc/compiler to fix the peerDependencies.

abdulsattar · 2026-01-14T21:25:52Z

 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"

-# Run the custom version check script


We need a test to prevent dependabot from updating dependencies beyond the approved range of each version.

Verify if dependabot acutaly updates aliases.

Document api versioning with wlc-dev-server. if (version === "262") { }

The CLI updates to the latest plugin always. Change teh frequency if it's too often and the bundle size too big.

Nick: reduce the bundle size instead.

abdulsattar · 2026-01-14T21:34:27Z

-      //
-      // Your org is on API version 63.0, but this version of the CLI plugin supports API version 62.0. To use the plugin with this org, you can reinstall or update the plugin using the "latest" tag. For example: "sf plugins install @salesforce/plugin-lightning-dev@latest".
+    // Priority 3: Skip check for testing (legacy compatibility)
+    if (process.env.SKIP_API_VERSION_CHECK === 'true') {


Remove this.

…ding - Added aliased dependencies for @lwc/lwc-dev-server, @lwc/sfdc-lwc-compiler, and lwc - Implemented DependencyLoader for dynamic runtime branching based on org API version - Removed 'version channel' concept in favor of direct API version mapping - Updated CLI commands to pass org connection for version detection - Added .husky/check-versions.js to ensure dependency/metadata alignment - Cleaned up unused VersionResolver and type utilities

nrkruk · 2026-01-28T16:04:26Z

  "extends": "@salesforce/dev-config/tsconfig-strict-esm",
  "compilerOptions": {
+    "module": "nodenext",
+    "moduleResolution": "nodenext",


what did you need this for?

Because we're reading package.json like so:

import packageJsonImport from '../../package.json' with { type: 'json' };

Without that we get this error in typescript:

src/shared/dependencyLoader.ts:18:52 - error TS2823: Import attributes are only supported when the '--module' option is set to 'esnext', 'nodenext', or 'preserve'.

nrkruk · 2026-01-28T16:08:33Z

@@ -0,0 +1,1103 @@
+# Design Proposal: Dual Version Support via NPM Aliasing


Not sure we need to include this file.

nrkruk · 2026-01-28T16:16:16Z

-    "@lwc/sfdc-lwc-compiler": "~13.3.8",
+    "@lwc/sfdx-local-dev-dist": "~13.3.16-alpha.0",
+    "@lwc/sfdx-local-dev-dist-66.0": "npm:@lwc/sfdx-local-dev-dist@~13.2.22",
+    "@lwc/sfdx-local-dev-dist-67.0": "npm:@lwc/sfdx-local-dev-dist@~13.3.16-alpha.0",


Suggested change

"@lwc/sfdx-local-dev-dist-67.0": "npm:@lwc/sfdx-local-dev-dist@~13.3.16-alpha.0",

"@lwc/sfdx-local-dev-dist-67.0": "npm:@lwc/sfdx-local-dev-dist@~13.3.16",

nrkruk · 2026-01-28T16:18:55Z

-    "target": {
-      "versionNumber": "67.0",
-      "matchingDevServerVersion": "~13.3.8"
+    "66.0": {


Can we include 258 "v65" also?

nrkruk · 2026-01-28T16:21:31Z

    "@inquirer/select": "^2.4.7",
-    "@lwc/lwc-dev-server": "~13.3.8",
-    "@lwc/sfdc-lwc-compiler": "~13.3.8",
+    "@lwc/sfdx-local-dev-dist": "~13.3.16-alpha.0",


Is this needed? I assume we'd just want @lwc/sfdx-local-dev-dist-65 here

nrkruk · 2026-01-28T16:21:51Z

+    "skipLibCheck": true,
+    "resolveJsonModule": true,
+    "module": "nodenext",
+    "moduleResolution": "nodenext"


again just curious about nodenext here

nrkruk · 2026-01-28T16:25:18Z

+
+// Type declarations for @lwc/sfdx-local-dev-dist aliases
+// The main package @lwc/sfdx-local-dev-dist provides its own type definitions
+declare module '@lwc/sfdx-local-dev-dist-65.0' {


we didn't include this yet in current pr?

nrkruk · 2026-01-28T16:26:11Z


 import { expect } from 'chai';
-import { Workspace } from '@lwc/lwc-dev-server';
+import { Workspace } from '@lwc/sfdx-local-dev-dist';


is this package just for test? If so it should be a dev dependency

nrkruk · 2026-01-28T16:27:00Z

  testIdentityData.usernameToServerEntityIdMap[testUsername] = testLdpServerId;

  beforeEach(async () => {
+    process.env.SKIP_API_VERSION_CHECK = 'true';


Do we need this in tests anymore?

nrkruk · 2026-01-28T18:32:32Z

    uses: salesforcecli/github-workflows/.github/workflows/unitTestsLinux.yml@main
    with:
-      skipTsDepCheck: true
+      skipTsDepCheck: false


re-enables typescript check in CI. Latest changes have made this work: https://github.com/salesforcecli/plugin-lightning-dev/actions/runs/21450379396/job/61777346502 🥳

nrkruk · 2026-01-28T18:33:30Z

@@ -1,24 +1,66 @@
 import fs from 'node:fs';
 import semver from 'semver';



Lets make sure this runs as part of a git workflow that blocks PR delivery

nrkruk

🥇 Amazing. Great job - thank you!

nrkruk · 2026-01-29T17:55:22Z

  }

  private async mobilePreview(
+    org: Org,


pass the connection here instead of the org

nrkruk · 2026-01-29T17:56:34Z

-    await startLWCServer(logger, sfdxProjectRootPath, ldpServerToken, Platform.desktop, serverPorts);
+    await startLWCServer(
+      logger,
+      org.getConnection(undefined),


we don't want to do this. We should be using const connection = targetOrg.getConnection(apiVersion);

You can always pass the connection from run() -> (line 93)

abdulsattar added 2 commits January 13, 2026 14:53

feat: use the right LWC/Dev server version for the org

4e42a9d

fix: tests

5438fb3

abdulsattar requested review from a team as code owners January 13, 2026 20:13

abdulsattar added 3 commits January 13, 2026 16:50

fix: remove check-versions script

cffc588

fix: types

1fc902c

fix: simplify versionresolver

7b6cde7

nrkruk self-requested a review January 14, 2026 17:34

abdulsattar added 4 commits January 14, 2026 14:10

fix: simplify dependency loader

86efeb1

fix: remove duplication

fc024f4

fix: remove deprecated ensureMatchingAPIVersion

0fcd4af

refactor: simplify VersionResolver and DependencyLoader and improve e…

2637a87

…rror handling

abdulsattar commented Jan 14, 2026

View reviewed changes

abdulsattar and others added 5 commits January 15, 2026 14:44

fix: use new package that has no peerDependencies

526a576

fix: use the right version for 260

d64c50a

chore(release): 6.0.2-canary.0 [skip ci]

6b0b6f0

fix: use latest lwc

cc32204

nrkruk reviewed Jan 28, 2026

View reviewed changes

fix: enable TypeScript dependency check in CI workflow

3e7c086

fix: use new lwc for 260

756f84c

nrkruk reviewed Jan 28, 2026

View reviewed changes

svc-cli-bot and others added 12 commits January 28, 2026 18:43

chore(release): 6.0.2-canary.1 [skip ci]

de78971

fix: add back 258

ba3ba9a

fix: add test to check versions

abb3e5e

fix: remove DUAL_VERSION.md

b27c5ef

fix: remove unused env var

8173b8d

fix: feedback

412780f

fix: yarn install

c58238c

Merge remote-tracking branch 'origin/main' into abdulsattar/dual-version

1ebfe92

fix: cleanup

4a4346d

fix: stuff

4b5df0f

fix: bump 66.0 to 13.2.23 for removing typescript

70df2f8

fix: fix 66.0 version

552ad0d

abdulsattar enabled auto-merge (squash) January 29, 2026 17:16

nrkruk approved these changes Jan 29, 2026

View reviewed changes

nrkruk disabled auto-merge January 29, 2026 17:50

nrkruk changed the title ~~feat: use the right LWC/Dev server version for the org~~ feat: use the right LWC/Dev server version for the org @W-20405334@ Jan 29, 2026

nrkruk reviewed Jan 29, 2026

View reviewed changes

svc-cli-bot and others added 4 commits January 29, 2026 18:00

chore(release): 6.1.1-canary.0 [skip ci]

246c67d

fix: remove 65.0 and use canary 66.0, 67.0

a8a737e

fix: feedback

f3675a7

fix: yarn install

f621699

abdulsattar merged commit 14f2f35 into main Jan 30, 2026
19 of 20 checks passed

abdulsattar deleted the abdulsattar/dual-version branch January 30, 2026 15:50


		# flags.version-channel.summary

		Manually specify which version channel to use (latest, prerelease, or next).

		@@ -0,0 +1,1103 @@
		# Design Proposal: Dual Version Support via NPM Aliasing

	"@lwc/sfdx-local-dev-dist-67.0": "npm:@lwc/sfdx-local-dev-dist@~13.3.16-alpha.0",
	"@lwc/sfdx-local-dev-dist-67.0": "npm:@lwc/sfdx-local-dev-dist@~13.3.16",

		@@ -1,24 +1,66 @@
		import fs from 'node:fs';
		import semver from 'semver';

Conversation

abdulsattar commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What issues does this PR fix or reference?

Uh oh!

nrkruk commented Jan 14, 2026

Uh oh!

abdulsattar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nrkruk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nrkruk Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abdulsattar commented Jan 13, 2026 •

edited

Loading

nrkruk Jan 29, 2026 •

edited

Loading